Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/onPreParse #130

Merged
merged 4 commits into from May 2, 2019

Conversation

@evanplaice
Copy link
Member

evanplaice commented May 2, 2019

This PR finishes implementing onPreParse. It should have been mutating the input string but without tests the functionality was never verified.

Checklist

  • Is this tested?
  • Is Documentation required?

Description

Finishes implementing this feature and adds tests to verify functionality.

evanplaice added 2 commits May 2, 2019
If defined, onPreParse should mutate the raw csv string.
@evanplaice evanplaice requested a review from coltonehrman May 2, 2019
The onPreParse hook takes 2 input params (csv, state).
@evanplaice evanplaice mentioned this pull request May 2, 2019
29 of 29 tasks complete
Copy link
Member

coltonehrman left a comment

Add onPreParse hook to the $.csv.toObjects onPreParse hook callback - should affect return value test

@evanplaice evanplaice merged commit ad9f49b into master May 2, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@evanplaice evanplaice deleted the feat/onPreParse branch May 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.