Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Add display:block to FontRuler so it can not be easily overridden. #182

Merged
merged 1 commit into from

2 participants

@bramstein
Owner

Needs review. This PR is to prevent people from accidentally setting display: none on our font load detection spans. This has happened in a few instances with global selectors.

@gregorkaplan
Owner

:+1:

@bramstein bramstein merged commit 5f47c83 into master
@bramstein bramstein deleted the bs-display-block branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
This page is out of date. Refresh to see the latest.
Showing with 1 addition and 1 deletion.
  1. +1 −1  src/core/fontruler.js
View
2  src/core/fontruler.js
@@ -38,7 +38,7 @@ goog.scope(function () {
* @return {string}
*/
FontRuler.prototype.computeStyleString_ = function(font) {
- return "position:absolute;top:-999px;left:-999px;" +
+ return "display:block;position:absolute;top:-999px;left:-999px;" +
"font-size:300px;width:auto;height:auto;line-height:normal;margin:0;" +
"padding:0;font-variant:normal;white-space:nowrap;font-family:" +
font.getCssName() + ";" + font.getCssVariation();
Something went wrong with that request. Please try again.