Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate sbt 1.x #212

Merged
merged 1 commit into from Feb 26, 2018

Conversation

@xuwei-k
Copy link
Contributor

commented Feb 11, 2018

No description provided.

@codecov-io

This comment has been minimized.

Copy link

commented Feb 11, 2018

Codecov Report

Merging #212 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #212   +/-   ##
======================================
  Coverage    76.4%   76.4%           
======================================
  Files          42      42           
  Lines         958     958           
  Branches       68      68           
======================================
  Hits          732     732           
  Misses        226     226

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31291e0...bc0d3ec. Read the comment docs.

@johnynek johnynek referenced this pull request Feb 15, 2018
@johnynek

This comment has been minimized.

Copy link
Collaborator

commented Feb 15, 2018

looks like my attempt to merge broke everything.

I'm not sure why people let me run projects when I know so little about sbt.

@ryan-williams

This comment has been minimized.

Copy link

commented Feb 16, 2018

I'm guessing your last comment was meant for #213 @johnynek ?

@johnynek

This comment has been minimized.

Copy link
Collaborator

commented Feb 16, 2018

@ryan-williams no, I tried to merge the conflict between here and #213 (which I merged). My attempt to do so failed, making the CI read for this PR that had previously been green (but conflicted with master).

@ryan-williams

This comment has been minimized.

Copy link

commented Feb 16, 2018

Ah I see, the earlier build "failed" due to codecov but passed tests.

It seems like the latest build passed tests but failed MiMa due to the cats upgrade.

I'm trying to figure out how to run the MiMa checks locally atm to mess with it… update: below comment is how to fix the build, I think.

.travis.yml Outdated
- ./sbt ++$TRAVIS_SCALA_VERSION clean coverage coreJVM/test lawsJVM/test coverageReport
- ./sbt ++$TRAVIS_SCALA_VERSION docs/makeMicrosite
- ./sbt "++${TRAVIS_SCALA_VERSION}!" clean coreJS/test lawsJS/test
- ./sbt "++${TRAVIS_SCALA_VERSION}!" clean coverage coreJVM/test lawsJVM/test coverageReport mimaReportBinaryIssues

This comment has been minimized.

Copy link
@ryan-williams

ryan-williams Feb 16, 2018

@johnynek this is why the build is failing now I think! #213 removed it due to the cats upgrade, but we're going to have to leave it out in any PRs that include that, until there's a new release to compare against

This comment has been minimized.

Copy link
@johnynek

johnynek Feb 16, 2018

Collaborator

Yep. I was the one who said we needed to remove but then manually added it back like a fool.

@johnynek

This comment has been minimized.

Copy link
Collaborator

commented Feb 16, 2018

Thanks y’all. I’ll merge and publish 1.0.0 tomorrow if nothing stops me.

@xuwei-k xuwei-k force-pushed the xuwei-k:sbt-1 branch from d4a65f5 to bc0d3ec Feb 25, 2018

@johnynek johnynek merged commit 0014a65 into typelevel:master Feb 26, 2018

3 checks passed

codecov/patch Coverage not affected when comparing 31291e0...bc0d3ec
Details
codecov/project 76.4% remains the same compared to 31291e0
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@johnynek

This comment has been minimized.

Copy link
Collaborator

commented Feb 26, 2018

Thank you @xuwei-k !

@xuwei-k xuwei-k deleted the xuwei-k:sbt-1 branch Feb 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.