New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Aggregate bench project #83
Conversation
Codecov Report
@@ Coverage Diff @@
## main #83 +/- ##
===========================================
- Coverage 96.14% 82.11% -14.03%
===========================================
Files 5 11 +6
Lines 648 794 +146
Branches 54 66 +12
===========================================
+ Hits 623 652 +29
- Misses 25 142 +117
Continue to review full report at Codecov.
|
602fdfc
to
e13966d
Compare
e13966d
to
d71b3db
Compare
but, this is how cross compilation works correctly
|
68e4441
to
84cf881
Compare
84cf881
to
8103442
Compare
🙌 alright so I guess this is now doing the expected. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for dealing with this. I know it can be a frustration to deal with the build.
@@ -55,7 +55,10 @@ jobs: | |||
- name: Check that workflows are up to date | |||
run: sbt ++${{ matrix.scala }} githubWorkflowCheck | |||
|
|||
- run: sbt ++${{ matrix.scala }} fmtCheck test mimaReportBinaryIssues | |||
- run: | | |||
sbt ++${{ matrix.scala }} fmtCheck \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do we need this change? Also, it is interesting there is no quote on the first item.
WorkflowStep.Sbt(List("fmtCheck", "test", "mimaReportBinaryIssues")) | ||
WorkflowStep.Run( | ||
List( | ||
"""sbt ++${{ matrix.scala }} fmtCheck \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess this is the difference, note the fmtCheck doesn't have quotes around it... But does it need the ++
at all? The format check does not depend on the scala version does it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The format check does not depend on the scala version does it?
selecting the scala version on format will allow us to check the format on scala version specific code i.e underscala-2.1x
folders. Currently we don't have any so we don't really need it. I thought of separating the "checks" into a separate CI step and run it for one version only but ended up keeping the previous behaviour; can be handy? why not?
The quotes are an interesting case and one of the weirdest behaviours in SBT. When running sbt like this(non interactive) Scala version is not correctly selected on projects when running tasks ... quoting them helps. However, the behavior is not the same on cmds like fmtCheck
and leads to error when it expands.
Note: from sbt console you don't need the quotes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the detailed reply.
With this we propagate
compile
andfmt
tasks/commands.