New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cats.evidence.Is and Scala 2.13 #2569

Open
durban opened this Issue Oct 19, 2018 · 1 comment

Comments

Projects
None yet
2 participants
@durban
Contributor

durban commented Oct 19, 2018

As far as I can tell, =:= in Scala 2.13 is very similar (identical?) in functionality to cats.evidence.Is. Would it make sense to revisit the decision regarding Is.unsafeFromPredef?

  • One thing is the unsafe prefix. Is it really unsafe? Especially now that in 2.13, it seems possible to write (A =:= B) => (A Is B) without any asInstanceOf.
  • The other (probably more important) is implicitness: if they're equivalent, maybe having an Is implicitly available when =:= is, would not be so bad.
@alexknvl

This comment has been minimized.

alexknvl commented Oct 22, 2018

It is not really unsafe. However, unless the support for 2.11 and 2.12 is dropped, it has to be implemented using coercion (asInstanceOf); having separate implementation for 2.12 and 2.13 would probably be undesirable in this particular case.

I think it would be nice to have it implicit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment