New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify some details about the life and death of Xor #1428

Merged
merged 1 commit into from Oct 25, 2016

Conversation

Projects
None yet
6 participants
@travisbrown
Collaborator

travisbrown commented Oct 25, 2016

These changes are minor, but to my ear "up to Cats 0.6.x" sounds like it excludes 0.6.x, and in any case Xor wasn't actually gone in 0.7. Since we're pointing to this FAQ entry in the 0.8.0 release / upgrade notes, I thought we should make the timing a little clearer. /cc @adelbertc

@travisbrown travisbrown referenced this pull request Oct 25, 2016

Merged

0.8.0 time! #1412

13 of 13 tasks complete
@kailuowang

This comment has been minimized.

Show comment
Hide comment
@kailuowang

kailuowang Oct 25, 2016

Member

👍

Member

kailuowang commented Oct 25, 2016

👍

@adelbertc

This comment has been minimized.

Show comment
Hide comment
@adelbertc

adelbertc Oct 25, 2016

Member

👍 on Travis green

Member

adelbertc commented Oct 25, 2016

👍 on Travis green

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Oct 25, 2016

Current coverage is 92.20% (diff: 100%)

Merging #1428 into master will not change coverage

@@             master      #1428   diff @@
==========================================
  Files           242        242          
  Lines          3606       3606          
  Methods        3537       3537          
  Messages          0          0          
  Branches         69         69          
==========================================
  Hits           3325       3325          
  Misses          281        281          
  Partials          0          0          

Powered by Codecov. Last update 93a4d6a...6b1b7fa

codecov-io commented Oct 25, 2016

Current coverage is 92.20% (diff: 100%)

Merging #1428 into master will not change coverage

@@             master      #1428   diff @@
==========================================
  Files           242        242          
  Lines          3606       3606          
  Methods        3537       3537          
  Messages          0          0          
  Branches         69         69          
==========================================
  Hits           3325       3325          
  Misses          281        281          
  Partials          0          0          

Powered by Codecov. Last update 93a4d6a...6b1b7fa

@peterneyens peterneyens merged commit 35c2bc0 into typelevel:master Oct 25, 2016

3 checks passed

codecov/patch Coverage not affected when comparing 93a4d6a...6b1b7fa
Details
codecov/project 92.20% (+0.00%) compared to 93a4d6a
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@stew stew removed the in progress label Oct 25, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment