Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add examples to Functor and verify with docstyle #2483

Merged
merged 1 commit into from Sep 12, 2018

Conversation

YuvalItzchakov
Copy link
Contributor

This PR implements #2479 for the Functor typeclass.

Would love feedback on the examples, if anything more complex is needed.

Copy link
Contributor

@kailuowang kailuowang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Nit: the indentation changed (from scaladoc convention to javadoc)

@YuvalItzchakov
Copy link
Contributor Author

@kailuowang Sorry about that, I assumed that we'd have a default scalafmt conf :)

@codecov-io
Copy link

Codecov Report

Merging #2483 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2483      +/-   ##
==========================================
- Coverage   95.38%   95.35%   -0.04%     
==========================================
  Files         357      357              
  Lines        6517     6517              
  Branches      279      282       +3     
==========================================
- Hits         6216     6214       -2     
- Misses        301      303       +2
Impacted Files Coverage Δ
core/src/main/scala/cats/Functor.scala 100% <ø> (ø) ⬆️
testkit/src/main/scala/cats/tests/Helpers.scala 96% <0%> (-4%) ⬇️
...rc/main/scala/cats/kernel/instances/function.scala 96.96% <0%> (-3.04%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92236f8...8a5bff7. Read the comment docs.

@YuvalItzchakov
Copy link
Contributor Author

@kailuowang LMK if there are any remaining issues with the indentation.

Copy link
Contributor

@kailuowang kailuowang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much!

@LukaJCB LukaJCB merged commit f285048 into typelevel:master Sep 12, 2018
@LukaJCB
Copy link
Member

LukaJCB commented Sep 12, 2018

Thanks Yuval! :)

@kailuowang kailuowang added this to the 1.4 milestone Sep 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants