Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to new kind-projector symbol #2929

Merged
merged 1 commit into from Jul 4, 2019

Conversation

@LukaJCB
Copy link
Member

commented Jul 2, 2019

We're going to deprecate the use of ? soon and we have * as a replacement for now. See this issue: typelevel/kind-projector#108

See here for the overall migration strategy: http://dotty.epfl.ch/docs/reference/changed-features/wildcards.html

@LukaJCB LukaJCB requested a review from kailuowang Jul 2, 2019

@codecov-io

This comment has been minimized.

Copy link

commented Jul 3, 2019

Codecov Report

Merging #2929 into master will not change coverage.
The diff coverage is 99.07%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2929   +/-   ##
=======================================
  Coverage   94.03%   94.03%           
=======================================
  Files         370      370           
  Lines        7038     7038           
  Branches      186      186           
=======================================
  Hits         6618     6618           
  Misses        420      420
Impacted Files Coverage Δ
core/src/main/scala/cats/ApplicativeError.scala 100% <ø> (ø) ⬆️
core/src/main/scala/cats/syntax/either.scala 86.76% <ø> (ø) ⬆️
core/src/main/scala/cats/Bifunctor.scala 100% <ø> (ø) ⬆️
core/src/main/scala/cats/data/EitherK.scala 93.18% <ø> (ø) ⬆️
.../src/main/scala/cats/syntax/applicativeError.scala 100% <ø> (ø) ⬆️
core/src/main/scala/cats/FlatMap.scala 86.66% <ø> (ø) ⬆️
core/src/main/scala/cats/Applicative.scala 95% <ø> (ø) ⬆️
core/src/main/scala/cats/data/Op.scala 87.5% <ø> (ø) ⬆️
core/src/main/scala/cats/syntax/TrySyntax.scala 100% <ø> (ø) ⬆️
core/src/main/scala/cats/syntax/option.scala 100% <ø> (ø) ⬆️
... and 50 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d29f7b...f893799. Read the comment docs.

@LukaJCB LukaJCB requested a review from fthomas Jul 3, 2019

@fthomas
fthomas approved these changes Jul 4, 2019

@kailuowang kailuowang merged commit e053e28 into master Jul 4, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@LukaJCB LukaJCB deleted the kind-projector-symbol branch Jul 4, 2019

@kailuowang kailuowang added this to the 2.0.0-RC1 milestone Aug 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.