Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bifold to Bifoldable close #2947. #2962

Open
wants to merge 2 commits into
base: master
from

Conversation

@takayahilton
Copy link
Contributor

commented Jul 25, 2019

No description provided.

@kailuowang kailuowang added this to the 2.1-RC1 milestone Aug 2, 2019
@kailuowang

This comment has been minimized.

Copy link
Member

commented Aug 2, 2019

We can't break BC yet, but we should be able to allow this soon, so I scheduled it to 2.1. Also it would be nice to have some tests.

@codecov-io

This comment has been minimized.

Copy link

commented Aug 5, 2019

Codecov Report

Merging #2962 into master will decrease coverage by 0.06%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2962      +/-   ##
==========================================
- Coverage   93.99%   93.92%   -0.07%     
==========================================
  Files         369      371       +2     
  Lines        7056     7062       +6     
  Branches      179      193      +14     
==========================================
+ Hits         6632     6633       +1     
- Misses        424      429       +5
Impacted Files Coverage Δ
core/src/main/scala/cats/Bifoldable.scala 83.33% <0%> (-7.58%) ⬇️
core/src/main/scala/cats/syntax/option.scala 100% <0%> (ø) ⬆️
testkit/src/main/scala/cats/tests/CatsSuite.scala 33.33% <0%> (ø)
...stkit/src/main/scala/cats/tests/CatsEquality.scala 66.66% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a786f15...b83fa3b. Read the comment docs.

@takayahilton takayahilton force-pushed the takayahilton:Add-bifold-to-Bifoldable branch from 01b2ba4 to b83fa3b Aug 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.