Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.14.1 release? #453

Open
ashawley opened this issue Feb 11, 2019 · 6 comments

Comments

@ashawley
Copy link
Collaborator

commented Feb 11, 2019

The last release of ScalaCheck was on Apr-22 2018.

Here's a proposal for a release:

1.14.1

Here are things already merged to master since 1.14.0:

  • Fix Arbitrary[Option[T]] so it is equivalent to Gen[Option[T]] #401
  • Allow Gen.oneOf to take argument of Iterable #438
  • Fix compilation error in Cogen with Scala 2.11.12 #403
  • Update Scala.js 1.x to 1.0.0-M6 #460
  • Fix compilation error in test runner for Java 9 and later #406
  • Fix compilation error in pretty-printer for Java 11 and later #430
  • Fix deprecation in ScalaCheck's internal tokenizer for Java 9 and later #433
  • Various corrections and improvements to the api docs: #415, #417, #420, #428
  • Test for Gen.pick should be more succinct #450
  • Add support for Either[T] #409
  • Fix Gen.posNum and Gen.negNum so it gives real numbers less than one #451
  • Fix shrinking of commands in 2.12 #468
  • Fix stackoverflow of Pretty.break #476.
  • Improve errors for test parameters #497.

There are a few PRs that are candidates but they need more review:

  • Show seed when failing test #400
  • Fixes for Dotty compiler #423
  • Overridding Properties.overrideParameters doesn't override parameters #463
  • Deprecate ambiguous implicit in Prop for Dotty #498

@ashawley ashawley closed this Feb 19, 2019

@rickynils

This comment has been minimized.

Copy link
Collaborator

commented Feb 22, 2019

@ashawley What was your reason for closing this? I think a new ScalaCheck release in the near future sounds like a good idea, and it looks like you did thorough research before opening this issue?

@nrinaudo

This comment has been minimized.

Copy link
Contributor

commented Jun 6, 2019

I’d vote for merging #468, since the command api is barely usable (for me) without that fix

@ashawley

This comment has been minimized.

Copy link
Collaborator Author

commented Jun 24, 2019

And there's a good chance that #468, failure to shrink Commands, could be causing secondary problems, such as #476.

@rajit

This comment has been minimized.

Copy link

commented Jul 5, 2019

It looks like 1.14.1 might not be far off. Is there anything I can do to help with the release?

@ashawley

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 8, 2019

I've added Dotty fixes in #423 to the list above, since it seems safe to include in 1.14.1.

@ashawley

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 8, 2019

A lot has been merged, so I updated the list above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.