Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Polynomial Gen #758

Merged
merged 1 commit into from Jan 31, 2019
Merged

Fix Polynomial Gen #758

merged 1 commit into from Jan 31, 2019

Conversation

@LukaJCB
Copy link
Member

LukaJCB commented Jan 16, 2019

Should address part of #756

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jan 16, 2019

Codecov Report

Merging #758 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #758      +/-   ##
==========================================
- Coverage   52.02%   52.01%   -0.01%     
==========================================
  Files         196      196              
  Lines       11904    11904              
  Branches     1649     1646       -3     
==========================================
- Hits         6193     6192       -1     
- Misses       5711     5712       +1
Impacted Files Coverage Δ
laws/src/main/scala/spire/laws/gen.scala 74.73% <0%> (ø) ⬆️
core/src/main/scala/spire/math/Algebraic.scala 65.44% <0%> (-2.65%) ⬇️
extras/src/main/scala/spire/math/FixedPoint.scala 34.97% <0%> (-0.55%) ⬇️
core/src/main/scala/spire/math/Rational.scala 95.29% <0%> (ø) ⬆️
core/src/main/scala/spire/math/Interval.scala 68.89% <0%> (+0.51%) ⬆️
...ala/spire/math/poly/BigDecimalRootRefinement.scala 83.44% <0%> (+0.66%) ⬆️
...ore/src/main/scala/spire/math/interval/Bound.scala 54.33% <0%> (+7.87%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9493c70...29bc8f2. Read the comment docs.

@tixxit

This comment has been minimized.

Copy link
Member

tixxit commented Jan 16, 2019

👍

@LukaJCB

This comment has been minimized.

Copy link
Member Author

LukaJCB commented Jan 31, 2019

Anything I can do to get this merged? :)

@tixxit tixxit merged commit e03aaed into typelevel:master Jan 31, 2019
1 of 3 checks passed
1 of 3 checks passed
codecov/patch 0% of diff hit (target 52.02%)
Details
codecov/project 52.01% (-0.01%) compared to 9493c70
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@LukaJCB LukaJCB deleted the LukaJCB:patch-1 branch Jan 31, 2019
@LukaJCB

This comment has been minimized.

Copy link
Member Author

LukaJCB commented Jan 31, 2019

Thanks!

JoeWrightss pushed a commit to JoeWrightss/spire that referenced this pull request Apr 13, 2019
…command

Agent healthcheck command
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.