Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

points in a bezierPath must be a tuple as it is immutable #350

Merged
merged 2 commits into from Jan 9, 2020

Conversation

@typemytype
Copy link
Owner

typemytype commented Dec 21, 2019

  • improve docs
+ improve docs
@codecov

This comment has been minimized.

Copy link

codecov bot commented Dec 21, 2019

Codecov Report

Merging #350 into master will not change coverage.
The diff coverage is 87.5%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #350   +/-   ##
=======================================
  Coverage   68.02%   68.02%           
=======================================
  Files          70       70           
  Lines        7314     7314           
=======================================
  Hits         4975     4975           
  Misses       2339     2339
Impacted Files Coverage Δ
drawBot/context/baseContext.py 76.97% <87.5%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 842fcf2...c4c48b2. Read the comment docs.


def _get_points(self):
return self._points()

points = property(_get_points, doc="Return a list of all points.")
points = property(_get_points, doc="Return a immutable list of all points in the bezierPath as point coordinate `(x, y)` tuples.")

This comment has been minimized.

Copy link
@justvanrossum

justvanrossum Dec 22, 2019

Collaborator

a -> an, same in the three following cases.

This comment has been minimized.

Copy link
@justvanrossum

justvanrossum Dec 22, 2019

Collaborator

Also: BezierPath (cap)

@typemytype typemytype merged commit 3db1987 into master Jan 9, 2020
3 checks passed
3 checks passed
codecov/patch 87.5% of diff hit (target 68.02%)
Details
codecov/project 68.02% (+0%) compared to 842fcf2
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@typemytype typemytype deleted the bezierPath_docs branch Jan 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.