Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove @DiscriminatorValue from error message #5256

Merged
merged 1 commit into from Oct 7, 2020
Merged

fix: remove @DiscriminatorValue from error message #5256

merged 1 commit into from Oct 7, 2020

Conversation

saulotoledo
Copy link
Contributor

Closes: #5255

@saulotoledo
Copy link
Contributor Author

@pleerock For review.

@imnotjames
Copy link
Contributor

imnotjames commented Oct 7, 2020 •
edited

Makes sense to me! Confirmed that the error message doesn't make sense any longer and this seems to bring it in line with new features.

@imnotjames imnotjames merged commit 2bf15ca into typeorm:master Oct 7, 2020
@imnotjames
Copy link
Contributor

Thanks for the contribution!

@imnotjames imnotjames added the hacktoberfest-accepted label hacktoberfest label Oct 7, 2020
zaro pushed a commit to zaro/typeorm that referenced this pull request Jan 12, 2021
@saulotoledo
fix: remove @DiscriminatorValue from error message (typeorm#5256)
cebdf1c 
Closes: typeorm#5255
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
hacktoberfest-accepted label hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error message asking for @DiscriminatorValue, removed a few versions ago
2 participants
@saulotoledo @imnotjames