Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recommend npm or yarn installation commands for packages #11

Closed
JoshuaKGoldberg opened this issue Jun 25, 2019 · 3 comments · Fixed by #405
Closed

Recommend npm or yarn installation commands for packages #11

JoshuaKGoldberg opened this issue Jun 25, 2019 · 3 comments · Fixed by #405
Labels
good first issue status: accepting prs type: enhancement

Comments

@JoshuaKGoldberg
Copy link
Collaborator

@JoshuaKGoldberg JoshuaKGoldberg commented Jun 25, 2019

When an ESLint configuration file is generated, at least the following packages will likely need to be available to use it:

  • eslint itself
  • @typescript-eslint/* plugins
  • Any other plugins extended from by the package, such as eslint-plugin-prettier

When this package is run successfully, there should be a (bright cyan?) recommendation for a shell command to install the requisite packages. It should use npm by default, or yarn if there is a yarn.lock.

@JoshuaKGoldberg JoshuaKGoldberg added type: enhancement status: accepting prs labels Jun 25, 2019
@JoshuaKGoldberg JoshuaKGoldberg added the good first issue label Aug 3, 2019
@KingDarBoja
Copy link
Collaborator

@KingDarBoja KingDarBoja commented Oct 7, 2019

Is possible to provide the user prompt to pick up an option to install all suggested packages based on npm | yarn | no options?

@JoshuaKGoldberg
Copy link
Collaborator Author

@JoshuaKGoldberg JoshuaKGoldberg commented Oct 7, 2019

@KingDarBoja yup, that sounds great!

@beenotung
Copy link
Contributor

@beenotung beenotung commented Jan 29, 2020

It would be nice to add an option for pnpm beside npm and yarn :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue status: accepting prs type: enhancement
Projects
None yet
3 participants