Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement variable-name rule converter #222

Merged
merged 6 commits into from Oct 10, 2019
Merged

Implement variable-name rule converter #222

merged 6 commits into from Oct 10, 2019

Conversation

KingDarBoja
Copy link
Collaborator

@KingDarBoja KingDarBoja commented Oct 6, 2019 •
edited by JoshuaKGoldberg

PR Checklist

Overview

  • Added a rule converter for variable-name in the TSLint ruleset.
  • Added proper handling for the options that come with the rule itself.
  • Added tests to make sure that the right comparative rules are being output.
  • Added a couple of notices so that the user is informed of things not automatically converted.

This is my first PR so don't expect it to be 100% perfect so awaiting for any feedback from members/contributors.

JoshuaKGoldberg
JoshuaKGoldberg requested changes Oct 6, 2019
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You bit off quite a complex set of rule changes 😀. This is a good start!

src/rules/converters/variable-name.ts Outdated Show resolved Hide resolved
src/rules/converters/variable-name.ts Outdated Show resolved Hide resolved
src/rules/converters/variable-name.ts Outdated Show resolved Hide resolved
src/rules/converters/variable-name.ts Outdated Show resolved Hide resolved
src/rules/converters/variable-name.ts Outdated Show resolved Hide resolved
src/rules/converters/variable-name.ts Outdated Show resolved Hide resolved
src/rules/converters/variable-name.ts Outdated Show resolved Hide resolved
src/rules/converters/variable-name.ts Outdated Show resolved Hide resolved
@JoshuaKGoldberg JoshuaKGoldberg added the status: waiting for author The PR author should address requested changes label Oct 6, 2019
@JoshuaKGoldberg JoshuaKGoldberg added status: waiting for reviewer Waiting for a maintainer to review and removed status: waiting for author The PR author should address requested changes labels Oct 7, 2019
JoshuaKGoldberg
JoshuaKGoldberg approved these changes Oct 7, 2019
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! A couple of stylistic requests here, but if you don't want to get to them in the next few days I can just merge this PR in as-is and make the changes myself. Up to you!

src/rules/converters/variable-name.ts Outdated Show resolved Hide resolved
src/rules/converters/variable-name.ts Show resolved Hide resolved
@JoshuaKGoldberg JoshuaKGoldberg added status: waiting for author The PR author should address requested changes and removed status: waiting for reviewer Waiting for a maintainer to review labels Oct 7, 2019
JoshuaKGoldberg
JoshuaKGoldberg approved these changes Oct 10, 2019
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent! Thanks so much for pushing through with this @KingDarBoja!

@JoshuaKGoldberg JoshuaKGoldberg merged commit bd694e7 into typescript-eslint:master Oct 10, 2019
@JoshuaKGoldberg JoshuaKGoldberg removed the status: waiting for author The PR author should address requested changes label Oct 10, 2019
@KingDarBoja KingDarBoja deleted the enhancement/variable-name-converter branch October 10, 2019 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing converter: variable-name
2 participants
@KingDarBoja @JoshuaKGoldberg