Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add no-caller and no-eval mergers #227

Merged
merged 1 commit into from Oct 7, 2019
Merged

Add no-caller and no-eval mergers #227

merged 1 commit into from Oct 7, 2019

Conversation

jeremyyap
Copy link
Contributor

PR Checklist

Overview

  • no-caller is quite straightforward as it has no options.
  • For no-eval I only set allowIndirect: true if both original and new options have it set to true, because otherwise at least one of the original TSLint rules would have flagged indirect eval calls out.

ESLint Docs

JoshuaKGoldberg
JoshuaKGoldberg approved these changes Oct 7, 2019
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is excellent! +1 to allowIndirect only being enabled if both rules had it. Thanks @jeremyyap!

@JoshuaKGoldberg JoshuaKGoldberg merged commit f0308e9 into typescript-eslint:master Oct 7, 2019
@jeremyyap jeremyyap deleted the add-missing-mergers branch October 7, 2019 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing mergers: no-caller, no-eval
2 participants
@jeremyyap @JoshuaKGoldberg