Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing output plugins to configuration file #706

Merged
merged 1 commit into from Sep 12, 2020

Conversation

JoshuaKGoldberg
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg commented Sep 8, 2020

PR Checklist

Overview

For some reason, writeConversionResults was ignoring the output plugins listed in the summarized results from converting rules. I can't think of why; we would want to include those plugins in the generated ESLint configuration file.

@JoshuaKGoldberg JoshuaKGoldberg added the status: waiting for reviewer Waiting for a maintainer to review label Sep 8, 2020
Copy link
Collaborator

@KingDarBoja KingDarBoja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 🍰

@JoshuaKGoldberg JoshuaKGoldberg merged commit 516d0e3 into main Sep 12, 2020
@KingDarBoja KingDarBoja deleted the output-plugins branch September 12, 2020 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: waiting for reviewer Waiting for a maintainer to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plugins not added when specified by rule converters
2 participants