Local check

typescript-eslint · Nov 17, 2020 · 2a4e958 · 2a4e958
1 parent 891693c
commit 2a4e958
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/packages/eslint-plugin/src/rules/no-unnecessary-condition.ts b/packages/eslint-plugin/src/rules/no-unnecessary-condition.ts
@@ -33,8 +33,6 @@ const isTruthyLiteral = (type: ts.Type): boolean =>
   isBooleanLiteralType(type, true) || (isLiteralType(type) && !!type.value);
 
 const isPossiblyFalsy = (type: ts.Type): boolean =>
-  isTypeUnknownType(type) ||
-  isTypeAnyType(type) ||
   unionTypeParts(type)
     // PossiblyFalsy flag includes literal values, so exclude ones that
     // are definitely truthy
@@ -452,6 +450,10 @@ export default createRule<Options, MessageId>({
           // Not a callable function
           return;
         }
+        // Predicate is always necessary if it involves `any` or `unknown`
+        if (returnTypes.some(t => isTypeAnyType(t) || isTypeUnknownType(t))) {
+          return;
+        }
         if (!returnTypes.some(isPossiblyFalsy)) {
           return context.report({
             node: callback,