fix(eslint-plugin): [no-unsafe-member-access] ignore MemberExpression…

…'s whose parents are either TSClassImplements or TSInterfaceHeritage (#2753)
typescript-eslint · Nov 11, 2020 · 535db3bf27ee1d7824ada9acd91d1b7833064628 · 535db3b
1 parent abe33fb
commit 535db3bf27ee1d7824ada9acd91d1b7833064628
Unified Split

Showing with 8 additions and 1 deletion.

+2 −1 packages/eslint-plugin/src/rules/no-unsafe-member-access.ts

+6 −0 packages/eslint-plugin/tests/rules/no-unsafe-member-access.test.ts
diff --git a/packages/eslint-plugin/src/rules/no-unsafe-member-access.ts b/packages/eslint-plugin/src/rules/no-unsafe-member-access.ts
@@ -71,7 +71,8 @@ export default util.createRule({
     }
 
     return {
-      MemberExpression: checkMemberExpression,
+      // ignore MemberExpression if it's parent is TSClassImplements or TSInterfaceHeritage
+      ':not(TSClassImplements, TSInterfaceHeritage) > MemberExpression': checkMemberExpression,
       'MemberExpression[computed = true] > *.property'(
         node: TSESTree.Expression,
       ): void {

diff --git a/packages/eslint-plugin/tests/rules/no-unsafe-member-access.test.ts b/packages/eslint-plugin/tests/rules/no-unsafe-member-access.test.ts
@@ -66,6 +66,12 @@ function foo(x?: string[]) {
   x?.[(1 as any)++];
 }
     `,
+    `
+class B implements FG.A {}
+    `,
+    `
+interface B extends FG.A {}
+    `,
   ],
   invalid: [
     ...batchedSingleLineTests({