fix(eslint-plugin): [no-extra-non-null-assertion] false positive with…

… non-nullable computed key (#2737)
typescript-eslint · Nov 5, 2020 · e82698c0ec796e460e40c3dd90a30bd100db05c2 · e82698c
1 parent c8a4dad
commit e82698c0ec796e460e40c3dd90a30bd100db05c2
Unified Split

Showing with 10 additions and 1 deletion.

+1 −1 packages/eslint-plugin/src/rules/no-extra-non-null-assertion.ts

+9 −0 packages/eslint-plugin/tests/rules/no-extra-non-null-assertion.test.ts
diff --git a/packages/eslint-plugin/src/rules/no-extra-non-null-assertion.ts b/packages/eslint-plugin/src/rules/no-extra-non-null-assertion.ts
@@ -32,7 +32,7 @@ export default util.createRule({
 
     return {
       'TSNonNullExpression > TSNonNullExpression': checkExtraNonNullAssertion,
-      'MemberExpression[optional = true] > TSNonNullExpression': checkExtraNonNullAssertion,
+      'MemberExpression[optional = true] > TSNonNullExpression.object': checkExtraNonNullAssertion,
       'CallExpression[optional = true] > TSNonNullExpression.callee': checkExtraNonNullAssertion,
     };
   },

diff --git a/packages/eslint-plugin/tests/rules/no-extra-non-null-assertion.test.ts b/packages/eslint-plugin/tests/rules/no-extra-non-null-assertion.test.ts
@@ -33,6 +33,15 @@ function foo(bar?: { n: number }) {
 checksCounter?.textContent!.trim();
       `,
     },
+    // https://github.com/typescript-eslint/typescript-eslint/issues/2732
+    {
+      code: `
+function foo(key: string | null) {
+  const obj = {};
+  return obj?.[key!];
+}
+      `,
+    },
   ],
   invalid: [
     {