Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
feat(typescript-estree): support for parsing 3.7 features #1045
Fixes #1033 (this doesn't add support for them in rules).
The AST I've gone with here is the same as the one babel (and flow) uses.
Lacking a better option, I figured this was a good AST rep to go with.
Thanks for the PR, @bradzacher!
typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.
The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.
@@ Coverage Diff @@ ## master #1045 +/- ## ========================================== + Coverage 94.01% 94.06% +0.04% ========================================== Files 115 115 Lines 5064 5086 +22 Branches 1416 1423 +7 ========================================== + Hits 4761 4784 +23 + Misses 175 174 -1 Partials 128 128
Yeah there's something weird with ts-jest, composite projects and ts 3.7.
Ill take another look.
edit: it stopped reproing locally because of the jest cache, running
I don't know why running the test individually "fixed" it. Running without the cache repros when running individually or as a batch.
edit: It seems like 3.7 is stricter with composite projects and project configs, so TS was erroring when the tests attempted to require a