Skip to content

Conversation

@JoshuaKGoldberg
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg commented May 6, 2025

PR Checklist

Overview

Relies on an CURRENT_MAJOR_VERSION env variable I've set in Netlify. You can preview it with a different version locally with:

CURRENT_MAJOR_VERSION=9001 yarn start

Screenshot of typescript-eslint.io with a big announcement banner: This documentation is for an older major version of typescript-eslint. It is no longer maintained or supported. It may crash with the latest versions of TypeScript. <hr /> Using the latest version of typescript-eslint is strongly recommended for getting the latest rule features and fixes,  supporting the latest TypeScript features and syntax, and continuous performance and stability improvements. <hr /> Please visit <a href="https://typescript-eslint.io">typescript-eslint.io</a> for the latest version's documentation.

💖

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify
Copy link

netlify bot commented May 6, 2025

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 2e92aa3
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/68221cc9fe9e20000967b48e
😎 Deploy Preview https://deploy-preview-11178--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 89 (🔴 down 10 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@nx-cloud
Copy link

nx-cloud bot commented May 6, 2025

View your CI Pipeline Execution ↗ for commit 2e92aa3.

Command Status Duration Result
nx typecheck ast-spec ✅ Succeeded <1s View ↗
nx run-many --target=build --exclude website --... ✅ Succeeded 2s View ↗
nx run-many --target=clean ✅ Succeeded 11s View ↗

☁️ Nx Cloud last updated this comment at 2025-05-14 20:05:17 UTC

@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as ready for review May 7, 2025 11:39
@JoshuaKGoldberg JoshuaKGoldberg requested a review from a team May 12, 2025 16:02
@codecov
Copy link

codecov bot commented May 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.92%. Comparing base (d5209cd) to head (2e92aa3).
Report is 16 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #11178   +/-   ##
=======================================
  Coverage   90.91%   90.92%           
=======================================
  Files         499      499           
  Lines       50809    50845   +36     
  Branches     8369     8384   +15     
=======================================
+ Hits        46195    46231   +36     
  Misses       4599     4599           
  Partials       15       15           
Flag Coverage Δ
unittest 90.92% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@JoshuaKGoldberg JoshuaKGoldberg added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label May 14, 2025
@JoshuaKGoldberg JoshuaKGoldberg merged commit d2dfe73 into typescript-eslint:main May 16, 2025
57 of 58 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Docs: link to docs for previous major versions, with the appropriate caveats

3 participants