Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(typescript-estree): fix filename handling for vue JSX + markdown #1127

Merged
merged 12 commits into from Nov 3, 2019

Conversation

@bradzacher
Copy link
Member

bradzacher commented Oct 22, 2019

Integrations I never knew existed:

  • JSX in vue files
  • Parsing of markdown snippets via eslint-plugin-markdown

Fixes #1123
Fixes #1124

@bradzacher bradzacher added the bug label Oct 22, 2019
@typescript-eslint

This comment has been minimized.

Copy link

typescript-eslint bot commented Oct 22, 2019

Thanks for the PR, @bradzacher!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@JounQin

This comment has been minimized.

Copy link

JounQin commented Oct 22, 2019

Can we add a test case for .mdx with eslint-plugin-mdx which is definitely different from eslint-plugin-markdown?

More detail: https://github.com/rx-ts/eslint-mdx

@bradzacher

This comment has been minimized.

Copy link
Member Author

bradzacher commented Oct 22, 2019

feel free to raise a PR with an integration test case for your tool if you want.
I don't know what MDX is, or how it works, so it would be better if you, as a maintainer of that project, adds an integration test.

The Vue stuff that we've added has been cobbled together by copy+pasting from issues that have been raised, and then those who know vue have PR'd modifications to the config appropriately.

@JounQin

This comment has been minimized.

Copy link

JounQin commented Oct 22, 2019

Thx for your explanation, I will raise another PR after your PR merged ASAP.

bradzacher added 4 commits Oct 23, 2019
@bradzacher bradzacher marked this pull request as ready for review Oct 23, 2019
@bradzacher bradzacher requested a review from JamesHenry Oct 23, 2019
bradzacher added 2 commits Oct 23, 2019
bradzacher added 3 commits Oct 30, 2019
@bradzacher bradzacher force-pushed the more-integrations branch from 8807bfb to 523384c Nov 1, 2019
@bradzacher bradzacher merged commit 366518f into master Nov 3, 2019
5 checks passed
5 checks passed
Semantic Pull Request ready to be squashed
Details
typescript-eslint.typescript-eslint Build #20191101.5 succeeded
Details
typescript-eslint.typescript-eslint (Primary code validation and tests) Primary code validation and tests succeeded
Details
typescript-eslint.typescript-eslint (Run unit tests on other Node.js versions node_10_x) Run unit tests on other Node.js versions node_10_x succeeded
Details
typescript-eslint.typescript-eslint (Run unit tests on other Node.js versions node_8_x) Run unit tests on other Node.js versions node_8_x succeeded
Details
@bradzacher bradzacher deleted the more-integrations branch Nov 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.