-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
test(eslint-plugin): [consistent-type-exports] add more shadowed imports tests #11766
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(eslint-plugin): [consistent-type-exports] add more shadowed imports tests #11766
Conversation
|
Thanks for the PR, @Tamashoo! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
View your CI Pipeline Execution ↗ for commit 493c1b2
☁️ Nx Cloud last updated this comment at |
JoshuaKGoldberg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Though, I'm not sure what to do given #11769. I suspect we should merge this in first, as it was sent earlier (we don't have any sort of issue claiming system), and see what's left to do with #11769 after?
|
There are two small issues ATM :)
I'd personally prefer checking |
|
@JoshuaKGoldberg @ntdiary Thanks |
Eh, for now, I don't feel strongly about adding those edge cases :), mainly because:
|
|
I'll go ahead and merge #11769 to |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #11766 +/- ##
=======================================
Coverage 90.49% 90.49%
=======================================
Files 522 522
Lines 53362 53367 +5
Branches 8913 8918 +5
=======================================
+ Hits 48288 48293 +5
Misses 5059 5059
Partials 15 15
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|

PR Checklist
Overview
This PR fixes the consistent-type-exports rule to correctly handle cases where imported types are shadowed by local value definitions.
I noticed @ntdiary mentioned working on this in the issue comments. I've submitted my approach here - maintainers, please feel free to compare both solutions and choose the one that works best, or we can collaborate to combine the best aspects of each!