Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(typescript-estree): reduce bundle footprint of tsutils #1177

Merged
merged 1 commit into from Nov 6, 2019

Conversation

@thorn0
Copy link
Contributor

thorn0 commented Nov 6, 2019

If you don't need everything offered by this package, you can select what should be imported.

-- from https://www.npmjs.com/package/tsutils

@typescript-eslint

This comment has been minimized.

Copy link

typescript-eslint bot commented Nov 6, 2019

Thanks for the PR, @thorn0!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

Copy link
Member

bradzacher left a comment

I didn't think about how big it would be for your web versions.

Thanks for this - LGTM

@codecov

This comment has been minimized.

Copy link

codecov bot commented Nov 6, 2019

Codecov Report

Merging #1177 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master    #1177   +/-   ##
=======================================
  Coverage   93.99%   93.99%           
=======================================
  Files         120      120           
  Lines        5195     5195           
  Branches     1440     1440           
=======================================
  Hits         4883     4883           
  Misses        178      178           
  Partials      134      134
Impacted Files Coverage Δ
packages/typescript-estree/src/convert-comments.ts 100% <100%> (ø) ⬆️
@bradzacher bradzacher merged commit c8fe515 into typescript-eslint:master Nov 6, 2019
7 checks passed
7 checks passed
Semantic Pull Request ready to be squashed
Details
codecov/patch 100% of diff hit (target 90%)
Details
codecov/project 93.99% (+0%) compared to f63c9c2
Details
typescript-eslint.typescript-eslint Build #20191106.1 succeeded
Details
typescript-eslint.typescript-eslint (Primary code validation and tests) Primary code validation and tests succeeded
Details
typescript-eslint.typescript-eslint (Run unit tests on other Node.js versions node_10_x) Run unit tests on other Node.js versions node_10_x succeeded
Details
typescript-eslint.typescript-eslint (Run unit tests on other Node.js versions node_8_x) Run unit tests on other Node.js versions node_8_x succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.