Skip to content

feat(typescript-estree): add tseslint.com redirects for CLI outputs#11895

Merged
JoshuaKGoldberg merged 5 commits intotypescript-eslint:mainfrom
JoshuaKGoldberg:tseslint.com
Jan 5, 2026
Merged

feat(typescript-estree): add tseslint.com redirects for CLI outputs#11895
JoshuaKGoldberg merged 5 commits intotypescript-eslint:mainfrom
JoshuaKGoldberg:tseslint.com

Conversation

@JoshuaKGoldberg
Copy link
Member

PR Checklist

Overview

Adds a very bare packages/tseslint.com that just has a minimal package.json and Netlify _redirects file. That redirects file has some preliminary listings for all the typescript-eslint.io/ results I could find in CLI outputs. Then it ends with a wildcard redirect for typescript-eslint.io/redirect/:splat for the 404 page.

In service of this, on Netlify I:

  1. Removed tseslint.com from the domains for the main project
  2. Created a new tseslint-redirects project that also pulls from this repo
  3. Configured that new project to go from the packages/tseslint.com directory

...and, voila! These links seem to work!

💖

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify
Copy link

netlify bot commented Dec 29, 2025

Deploy Preview for tseslint-redirects canceled.

Name Link
🔨 Latest commit 4b3acfd
🔍 Latest deploy log https://app.netlify.com/projects/tseslint-redirects/deploys/695b248956d97400084b94e3

@netlify
Copy link

netlify bot commented Dec 29, 2025

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 4b3acfd
🔍 Latest deploy log https://app.netlify.com/projects/typescript-eslint/deploys/695b2489b8751f000819903f
😎 Deploy Preview https://deploy-preview-11895--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 89 (🔴 down 1 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@nx-cloud
Copy link

nx-cloud bot commented Dec 29, 2025

View your CI Pipeline Execution ↗ for commit 4b3acfd

Command Status Duration Result
nx run-many -t lint ✅ Succeeded 3m 14s View ↗
nx run-many -t typecheck ✅ Succeeded 2m 12s View ↗
nx test typescript-estree --coverage=false ✅ Succeeded 21s View ↗
nx test eslint-plugin-internal --coverage=false ✅ Succeeded 10s View ↗
nx run types:build ✅ Succeeded 2s View ↗
nx run generate-configs ✅ Succeeded 8s View ↗
nx run integration-tests:test ✅ Succeeded 3s View ↗
nx run-many --target=build --parallel --exclude... ✅ Succeeded 20s View ↗
Additional runs (28) ✅ Succeeded ... View ↗

☁️ Nx Cloud last updated this comment at 2026-01-05 02:54:21 UTC

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might require some reconfiguration on the Netlify deploy side. But I think it should be fine / configurable, right?

@codecov
Copy link

codecov bot commented Dec 29, 2025

Codecov Report

❌ Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 90.67%. Comparing base (95c7c73) to head (4b3acfd).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
packages/typescript-estree/src/convert.ts 50.00% 1 Missing ⚠️

❌ Your patch status has failed because the patch coverage (83.33%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11895      +/-   ##
==========================================
- Coverage   90.67%   90.67%   -0.01%     
==========================================
  Files         525      525              
  Lines       53480    53479       -1     
  Branches     8928     8928              
==========================================
- Hits        48491    48490       -1     
  Misses       4976     4976              
  Partials       13       13              
Flag Coverage Δ
unittest 90.67% <83.33%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ee/src/create-program/createProjectProgramError.ts 100.00% <100.00%> (ø)
...eate-program/validateDefaultProjectForFilesGlob.ts 100.00% <ø> (ø)
...ree/src/parseSettings/candidateTSConfigRootDirs.ts 100.00% <100.00%> (ø)
...ckages/utils/src/eslint-utils/getParserServices.ts 100.00% <100.00%> (ø)
packages/typescript-estree/src/convert.ts 31.79% <50.00%> (-0.03%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bradzacher bradzacher changed the title feat: add tseslint.com redirects package chore: add tseslint.com redirects package Dec 29, 2025
bradzacher
bradzacher previously approved these changes Dec 29, 2025
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if there's a lint rule we can write which scans mdx and ts/tsx files for URLs in strings and ensures the shortlinks actually exist in the redirect config.

@JoshuaKGoldberg JoshuaKGoldberg added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Dec 29, 2025
@JoshuaKGoldberg
Copy link
Member Author

Yeah that'd be a nifty one... I guess we'll see if we end up needing it.

@JoshuaKGoldberg JoshuaKGoldberg changed the title chore: add tseslint.com redirects package feat: add tseslint.com redirects package Dec 29, 2025
@JoshuaKGoldberg
Copy link
Member Author

I realized after sending that I should have labeled this as feat:, since it does touch user-facing CLI outputs.

@JoshuaKGoldberg JoshuaKGoldberg changed the title feat: add tseslint.com redirects package feat(typescript-estree): add tseslint.com redirects for CLI outputs Dec 29, 2025
@JoshuaKGoldberg JoshuaKGoldberg merged commit c036392 into typescript-eslint:main Jan 5, 2026
68 of 69 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Docs: Use a URL shortener for links printed by code

2 participants