fix(eslint-plugin): [no-base-to-string] detect @@toPrimitive and valueOf by JoshuaKGoldberg · Pull Request #11901 · typescript-eslint/typescript-eslint

JoshuaKGoldberg · 2025-12-29T17:36:05Z

PR Checklist

Addresses an existing open issue: fixes Bug: [no-base-to-string] Should detect @@toPrimitive and valueOf #6048
That issue was marked as accepting prs
Steps in Contributing were taken

Overview

I had to add a little intermediary logic to the "does a known property exist?" logic. Just adding another ?? checker.getPropertyOfType(type, "valueOf") meant that types declared on Object would get detected before those declared by the user. The new isToStringLikeFromObject function instead tries to find a user-declared one, but also remembers if it found one declared on Object as a backup/fallback.

💖

typescript-eslint · 2025-12-29T17:36:08Z

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

netlify · 2025-12-29T17:36:11Z

✅ Deploy Preview for typescript-eslint ready!

Name	Link
🔨 Latest commit	`f33472f`
🔍 Latest deploy log	https://app.netlify.com/projects/typescript-eslint/deploys/6952cf71b8d79400088eacb2
😎 Deploy Preview	https://deploy-preview-11901--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 98 (🟢 up 8 from production) Accessibility: 97 (no change from production) Best Practices: 100 (no change from production) SEO: 92 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

nx-cloud · 2025-12-29T17:37:34Z

View your CI Pipeline Execution ↗ for commit f33472f

Command	Status	Duration	Result
`nx run-many -t lint`	✅ Succeeded	4m 28s	View ↗
`nx run-many -t typecheck`	✅ Succeeded	1m 57s	View ↗
`nx test eslint-plugin-internal --coverage=false`	✅ Succeeded	2s	View ↗
`nx run types:build`	✅ Succeeded	2s	View ↗
`nx test typescript-estree --coverage=false`	✅ Succeeded	1s	View ↗
`nx run generate-configs`	✅ Succeeded	7s	View ↗
`nx run integration-tests:test`	✅ Succeeded	4s	View ↗
`nx run-many --target=build --parallel --exclude...`	✅ Succeeded	6s	View ↗
`Additional runs (28)`	✅ Succeeded	...	View ↗

☁️ Nx Cloud last updated this comment at 2025-12-29 19:10:31 UTC

codecov · 2025-12-29T17:48:38Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.68%. Comparing base (2b0d14b) to head (f33472f).
⚠️ Report is 17 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #11901      +/-   ##
==========================================
+ Coverage   90.67%   90.68%   +0.01%     
==========================================
  Files         524      524              
  Lines       53470    53514      +44     
  Branches     8928     8944      +16     
==========================================
+ Hits        48484    48530      +46     
+ Misses       4973     4971       -2     
  Partials       13       13

Flag	Coverage Δ
unittest	`90.68% <100.00%> (+0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
...kages/eslint-plugin/src/rules/no-base-to-string.ts	`99.70% <100.00%> (+0.69%)`	⬆️

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

| datasource | package | from | to | | ---------- | -------------------------------- | ------ | ------ | | npm | @typescript-eslint/eslint-plugin | 8.51.0 | 8.52.0 | | npm | @typescript-eslint/parser | 8.51.0 | 8.52.0 | ## [v8.52.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8520-2026-01-05) ##### 🚀 Features - **eslint-plugin-internal:** \[no-multiple-lines-of-errors] add rule ([#11899](typescript-eslint/typescript-eslint#11899)) ##### 🩹 Fixes - **eslint-plugin:** \[no-base-to-string] detect @[@toPrimitive](https://github.com/toPrimitive) and valueOf ([#11901](typescript-eslint/typescript-eslint#11901)) - **eslint-plugin:** \[no-useless-default-assignment] handle conditional initializer ([#11908](typescript-eslint/typescript-eslint#11908)) ##### ❤️ Thank You - Josh Goldberg ✨ - Ulrich Stark You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.

This MR contains the following updates: | Package | Type | Update | Change | OpenSSF | |---|---|---|---|---| | [@mui/x-charts](https://mui.com/x/react-charts/) ([source](https://github.com/mui/mui-x/tree/HEAD/packages/x-charts)) | dependencies | minor | [`8.23.0` → `8.24.0`](https://renovatebot.com/diffs/npm/@mui%2fx-charts/8.23.0/8.24.0) | [![OpenSSF Scorecard](https://api.securityscorecards.dev/projects/github.com/mui/mui-x/badge)](https://securityscorecards.dev/viewer/?uri=github.com/mui/mui-x) | | [@mui/x-tree-view](https://mui.com/x/react-tree-view/) ([source](https://github.com/mui/mui-x/tree/HEAD/packages/x-tree-view)) | dependencies | minor | [`8.23.0` → `8.24.0`](https://renovatebot.com/diffs/npm/@mui%2fx-tree-view/8.23.0/8.24.0) | [![OpenSSF Scorecard](https://api.securityscorecards.dev/projects/github.com/mui/mui-x/badge)](https://securityscorecards.dev/viewer/?uri=github.com/mui/mui-x) | | [@openapitools/openapi-generator-cli](https://github.com/OpenAPITools/openapi-generator-cli) | devDependencies | minor | [`2.26.0` → `2.27.0`](https://renovatebot.com/diffs/npm/@openapitools%2fopenapi-generator-cli/2.26.0/2.27.0) | [![OpenSSF Scorecard](https://api.securityscorecards.dev/projects/github.com/OpenAPITools/openapi-generator-cli/badge)](https://securityscorecards.dev/viewer/?uri=github.com/OpenAPITools/openapi-generator-cli) | | [@typescript-eslint/eslint-plugin](https://typescript-eslint.io/packages/eslint-plugin) ([source](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin)) | devDependencies | minor | [`8.51.0` → `8.53.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2feslint-plugin/8.51.0/8.53.0) | [![OpenSSF Scorecard](https://api.securityscorecards.dev/projects/github.com/typescript-eslint/typescript-eslint/badge)](https://securityscorecards.dev/viewer/?uri=github.com/typescript-eslint/typescript-eslint) | | [@typescript-eslint/parser](https://typescript-eslint.io/packages/parser) ([source](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser)) | devDependencies | minor | [`8.51.0` → `8.53.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2fparser/8.51.0/8.53.0) | [![OpenSSF Scorecard](https://api.securityscorecards.dev/projects/github.com/typescript-eslint/typescript-eslint/badge)](https://securityscorecards.dev/viewer/?uri=github.com/typescript-eslint/typescript-eslint) | | [react-router-dom](https://github.com/remix-run/react-router) ([source](https://github.com/remix-run/react-router/tree/HEAD/packages/react-router-dom)) | dependencies | minor | [`7.11.0` → `7.12.0`](https://renovatebot.com/diffs/npm/react-router-dom/7.11.0/7.12.0) | [![OpenSSF Scorecard](https://api.securityscorecards.dev/projects/github.com/remix-run/react-router/badge)](https://securityscorecards.dev/viewer/?uri=github.com/remix-run/react-router) | --- ### Release Notes <details> <summary>mui/mui-x (@mui/x-charts)</summary> ### [`v8.24.0`](https://github.com/mui/mui-x/blob/HEAD/CHANGELOG.md#8240) [Compare Source](mui/mui-x@v8.23.0...v8.24.0) *Jan 8, 2026* We'd like to extend a big thank you to the 12 contributors who made this release possible. Here are some highlights ✨: - ⚡️Add bar [batch renderer](https://mui.com/x/react-charts/bars/#performance), result in a significant performance improvement when rendering thousands of bars - 📊 Add [range bar chart](https://mui.com/x/react-charts/range-bar/) to render ![image](https://github.com/user-attachments/assets/4112c09b-d841-42f7-a0c8-d23b61c23ca0) - 🌎 Improved Danish (da-DK) and Japanese (ja-JP) locales on the Data Grid Special thanks go out to these community members for their valuable contributions: [@anders-noerrelykke](https://github.com/anders-noerrelykke), [@auloin](https://github.com/auloin), [@sai6855](https://github.com/sai6855), [@yuito-it](https://github.com/yuito-it) The following team members contributed to this release: [@alelthomas](https://github.com/alelthomas), [@alexfauquette](https://github.com/alexfauquette), [@arminmeh](https://github.com/arminmeh), [@bernardobelchior](https://github.com/bernardobelchior), [@flaviendelangle](https://github.com/flaviendelangle), [@JCQuintas](https://github.com/JCQuintas), [@mapache-salvaje](https://github.com/mapache-salvaje), [@siriwatknp](https://github.com/siriwatknp) ##### Data Grid ##### `@mui/x-data-grid@8.24.0` - \[l10n] Improve Danish (da-DK) locale ([#20828](mui/mui-x#20828)) [@anders-noerrelykke](https://github.com/anders-noerrelykke) - \[l10n] Improve Japanese (ja-JP) locale ([#20251](mui/mui-x#20251)) [@yuito-it](https://github.com/yuito-it) ##### `@mui/x-data-grid-pro@8.24.0` [![pro](https://mui.com/r/x-pro-svg)](https://mui.com/r/x-pro-svg-link "Pro plan") Same changes as in `@mui/x-data-grid@8.24.0`, plus: - \[DataGridPro] Fix header filter height for `density="compact"` ([#20834](mui/mui-x#20834)) [@arminmeh](https://github.com/arminmeh) ##### `@mui/x-data-grid-premium@8.24.0` [![premium](https://mui.com/r/x-premium-svg)](https://mui.com/r/x-premium-svg-link "Premium plan") Same changes as in `@mui/x-data-grid-pro@8.24.0`. ##### Date and Time Pickers ##### `@mui/x-date-pickers@8.24.0` - \[pickers] Fix Styles applied to PickersDay when MuiPickersDay-dayOutsideMonth is used ([#20719](mui/mui-x#20719)) [@sai6855](https://github.com/sai6855) ##### `@mui/x-date-pickers-pro@8.24.0` [![pro](https://mui.com/r/x-pro-svg)](https://mui.com/r/x-pro-svg-link "Pro plan") Same changes as in `@mui/x-date-pickers@8.24.0`. ##### Charts ##### `@mui/x-charts@8.24.0` - \[charts] Add `VisibilityManager` logic to allow managing series/items ([#20571](mui/mui-x#20571)) [@JCQuintas](https://github.com/JCQuintas) - \[charts] Add `identifierSerializer` configuration ([#20775](mui/mui-x#20775)) [@JCQuintas](https://github.com/JCQuintas) - \[charts] Add `serializeIdentifier` instance function ([#20791](mui/mui-x#20791)) [@JCQuintas](https://github.com/JCQuintas) - \[charts] Add bar batch renderer ([#20457](mui/mui-x#20457)) [@bernardobelchior](https://github.com/bernardobelchior) - \[charts] Allow animating bar, line, and pie elements to hidden state ([#20798](mui/mui-x#20798)) [@JCQuintas](https://github.com/JCQuintas) - \[charts] Fix failing lint step ([#20813](mui/mui-x#20813)) [@bernardobelchior](https://github.com/bernardobelchior) - \[charts] Fix tooltip anchored to item ([#20783](mui/mui-x#20783)) [@alexfauquette](https://github.com/alexfauquette) - \[charts] Fix type casting in getCategoryAxisConfig and applySeriesLayout functions ([#20797](mui/mui-x#20797)) [@sai6855](https://github.com/sai6855) - \[charts] Let keyboard navigation avoid overflow and handle nullish values ([#20757](mui/mui-x#20757)) [@alexfauquette](https://github.com/alexfauquette) - \[charts] Refactor `PieChart` and `PieChartPro` to use `slots` and `slotProps` directly ([#20795](mui/mui-x#20795)) [@sai6855](https://github.com/sai6855) - \[charts] Refactor `useRegisterPointerEventHandlers` ([#20824](mui/mui-x#20824)) [@bernardobelchior](https://github.com/bernardobelchior) - \[charts] Update legend types to allow hiding/showing items ([#20784](mui/mui-x#20784)) [@JCQuintas](https://github.com/JCQuintas) ##### `@mui/x-charts-pro@8.24.0` [![pro](https://mui.com/r/x-pro-svg)](https://mui.com/r/x-pro-svg-link "Pro plan") Same changes as in `@mui/x-charts@8.24.0`, plus: - \[charts-pro] Pass `slotProps.toolbar` to `Toolbar` in `PieChartPro` ([#20796](mui/mui-x#20796)) [@sai6855](https://github.com/sai6855) ##### `@mui/x-charts-premium@8.24.0` [![premium](https://mui.com/r/x-premium-svg)](https://mui.com/r/x-premium-svg-link "Premium plan") Same changes as in `@mui/x-charts-pro@8.24.0`, plus: - \[charts-premium] Add range bar chart ([#20275](mui/mui-x#20275)) [@bernardobelchior](https://github.com/bernardobelchior) ##### Tree View ##### `@mui/x-tree-view@8.24.0` - \[tree view] Introduce a Tree View Store to clean the internals ([#20051](mui/mui-x#20051)) [@flaviendelangle](https://github.com/flaviendelangle) ##### `@mui/x-tree-view-pro@8.24.0` [![pro](https://mui.com/r/x-pro-svg)](https://mui.com/r/x-pro-svg-link "Pro plan") Same changes as in `@mui/x-tree-view@8.24.0`. ##### Codemod ##### `@mui/x-codemod@8.24.0` Internal changes. ##### Docs - \[docs] Fix axis size default values ([#20799](mui/mui-x#20799)) [@bernardobelchior](https://github.com/bernardobelchior) - \[docs] Update What's New in MUI X page with post v8 features (DX-118) ([#20787](mui/mui-x#20787)) [@alelthomas](https://github.com/alelthomas) - \[docs] Fix `onAccept`'s `context.source` documentation to use 'view' instead of 'picker' ([#20465](mui/mui-x#20465)) [@auloin](https://github.com/auloin) - \[docs] Revise the Charts Brush doc ([#20792](mui/mui-x#20792)) [@mapache-salvaje](https://github.com/mapache-salvaje) - \[docs] Revise the Charts Highlighting doc ([#20788](mui/mui-x#20788)) [@mapache-salvaje](https://github.com/mapache-salvaje) - \[docs] Revise the Charts Label doc ([#20794](mui/mui-x#20794)) [@mapache-salvaje](https://github.com/mapache-salvaje) - \[docs] Revise the Charts Export doc ([#20779](mui/mui-x#20779)) [@mapache-salvaje](https://github.com/mapache-salvaje) ##### Core - \[code-infra] Fix v8.23.0 release date ([#20767](mui/mui-x#20767)) [@bernardobelchior](https://github.com/bernardobelchior) - \[code-infra] Remove `glob-gitignore` ([#20801](mui/mui-x#20801)) [@bernardobelchior](https://github.com/bernardobelchior) - \[code-infra] Remove `nyc` ([#20804](mui/mui-x#20804)) [@bernardobelchior](https://github.com/bernardobelchior) - \[code-infra] Remove `stream-browserify` and `null-loader` ([#20805](mui/mui-x#20805)) [@bernardobelchior](https://github.com/bernardobelchior) - \[code-infra] Remove `stylelint-config-tailwindcss` ([#20807](mui/mui-x#20807)) [@bernardobelchior](https://github.com/bernardobelchior) - \[code-infra] Remove unused `path` package ([#20802](mui/mui-x#20802)) [@bernardobelchior](https://github.com/bernardobelchior) - \[code-infra] Retry flaky e2e test on webkit ([#20806](mui/mui-x#20806)) [@JCQuintas](https://github.com/JCQuintas) - \[internal] Add `internal` slot to properly generate components CSS layer ([#20763](mui/mui-x#20763)) [@siriwatknp](https://github.com/siriwatknp) </details> <details> <summary>OpenAPITools/openapi-generator-cli (@openapitools/openapi-generator-cli)</summary> ### [`v2.27.0`](https://github.com/OpenAPITools/openapi-generator-cli/releases/tag/v2.27.0) [Compare Source](OpenAPITools/openapi-generator-cli@v2.26.0...v2.27.0) ##### Features - **config:** add support for environment variable placeholders in config ([#1031](OpenAPITools/openapi-generator-cli#1031)) ([1cd2614](OpenAPITools/openapi-generator-cli@1cd2614)) </details> <details> <summary>typescript-eslint/typescript-eslint (@typescript-eslint/eslint-plugin)</summary> ### [`v8.53.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8530-2026-01-12) [Compare Source](typescript-eslint/typescript-eslint@v8.52.0...v8.53.0) ##### 🚀 Features - **eslint-plugin:** add rule \[strict-void-return] ([#9707](typescript-eslint/typescript-eslint#9707)) - **eslint-plugin:** \[no-unused-vars] add a fixer to remove unused imports ([#11922](typescript-eslint/typescript-eslint#11922)) ##### 🩹 Fixes - **eslint-plugin:** \[no-useless-default-assignment] fix false positive for parameters corresponding to a rest parameter ([#11916](typescript-eslint/typescript-eslint#11916)) - **eslint-plugin:** replace unclear "`error` typed" with more helpful description ([#11704](typescript-eslint/typescript-eslint#11704)) - **typescript-estree:** forbid invalid `extends` and `implements` in interface declaration ([#11935](typescript-eslint/typescript-eslint#11935)) - **typescript-estree:** forbid invalid class implements ([#11934](typescript-eslint/typescript-eslint#11934)) - **typescript-estree:** forbid type-only import with both default and named specifiers ([#11930](typescript-eslint/typescript-eslint#11930)) ##### ❤️ Thank You - Brad Zacher [@bradzacher](https://github.com/bradzacher) - fisker Cheung [@fisker](https://github.com/fisker) - Josh Goldberg - Josh Goldberg ✨ - Kirk Waiblinger - Niki [@phaux](https://github.com/phaux) - Nikita - SungHyun627 [@SungHyun627](https://github.com/SungHyun627) - Will Harney [@wjhsf](https://github.com/wjhsf) You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website. ### [`v8.52.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8520-2026-01-05) [Compare Source](typescript-eslint/typescript-eslint@v8.51.0...v8.52.0) ##### 🚀 Features - **eslint-plugin-internal:** \[no-multiple-lines-of-errors] add rule ([#11899](typescript-eslint/typescript-eslint#11899)) ##### 🩹 Fixes - **eslint-plugin:** \[no-base-to-string] detect @[@toPrimitive](https://github.com/toPrimitive) and valueOf ([#11901](typescript-eslint/typescript-eslint#11901)) - **eslint-plugin:** \[no-useless-default-assignment] handle conditional initializer ([#11908](typescript-eslint/typescript-eslint#11908)) ##### ❤️ Thank You - Josh Goldberg ✨ - Ulrich Stark You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website. </details> <details> <summary>typescript-eslint/typescript-eslint (@typescript-eslint/parser)</summary> ### [`v8.53.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#8530-2026-01-12) [Compare Source](typescript-eslint/typescript-eslint@v8.52.0...v8.53.0) This was a version bump only for parser to align it with other projects, there were no code changes. You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website. ### [`v8.52.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#8520-2026-01-05) [Compare Source](typescript-eslint/typescript-eslint@v8.51.0...v8.52.0) This was a version bump only for parser to align it with other projects, there were no code changes. You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website. </details> <details> <summary>remix-run/react-router (react-router-dom)</summary> ### [`v7.12.0`](https://github.com/remix-run/react-router/blob/HEAD/packages/react-router-dom/CHANGELOG.md#7120) [Compare Source](https://github.com/remix-run/react-router/compare/react-router-dom@7.11.0...react-router-dom@7.12.0) ##### Patch Changes - Updated dependencies: - `react-router@7.12.0` </details> --- - [ ] If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  See merge request swiss-armed-forces/cyber-command/cea/loom!243 Co-authored-by: shrewd-laidback palace <shrewd-laidback-palace-736-c41-2c1-e464fc974@swiss-armed-forces-open-source.ch> Co-authored-by: Loom MR Pipeline Trigger <group_103951964_bot_9504bb8dead6d4e406ad817a607f24be@noreply.gitlab.com>

chore(deps): update frontend dependencies (minor) (minor) This MR contains the following updates: | Package | Type | Update | Change | OpenSSF | |---|---|---|---|---| | [@mui/x-charts](https://mui.com/x/react-charts/) ([source](https://github.com/mui/mui-x/tree/HEAD/packages/x-charts)) | dependencies | minor | [`8.23.0` → `8.24.0`](https://renovatebot.com/diffs/npm/@mui%2fx-charts/8.23.0/8.24.0) | [![OpenSSF Scorecard](https://api.securityscorecards.dev/projects/github.com/mui/mui-x/badge)](https://securityscorecards.dev/viewer/?uri=github.com/mui/mui-x) | | [@mui/x-tree-view](https://mui.com/x/react-tree-view/) ([source](https://github.com/mui/mui-x/tree/HEAD/packages/x-tree-view)) | dependencies | minor | [`8.23.0` → `8.24.0`](https://renovatebot.com/diffs/npm/@mui%2fx-tree-view/8.23.0/8.24.0) | [![OpenSSF Scorecard](https://api.securityscorecards.dev/projects/github.com/mui/mui-x/badge)](https://securityscorecards.dev/viewer/?uri=github.com/mui/mui-x) | | [@openapitools/openapi-generator-cli](https://github.com/OpenAPITools/openapi-generator-cli) | devDependencies | minor | [`2.26.0` → `2.27.0`](https://renovatebot.com/diffs/npm/@openapitools%2fopenapi-generator-cli/2.26.0/2.27.0) | [![OpenSSF Scorecard](https://api.securityscorecards.dev/projects/github.com/OpenAPITools/openapi-generator-cli/badge)](https://securityscorecards.dev/viewer/?uri=github.com/OpenAPITools/openapi-generator-cli) | | [@typescript-eslint/eslint-plugin](https://typescript-eslint.io/packages/eslint-plugin) ([source](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin)) | devDependencies | minor | [`8.51.0` → `8.53.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2feslint-plugin/8.51.0/8.53.0) | [![OpenSSF Scorecard](https://api.securityscorecards.dev/projects/github.com/typescript-eslint/typescript-eslint/badge)](https://securityscorecards.dev/viewer/?uri=github.com/typescript-eslint/typescript-eslint) | | [@typescript-eslint/parser](https://typescript-eslint.io/packages/parser) ([source](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser)) | devDependencies | minor | [`8.51.0` → `8.53.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2fparser/8.51.0/8.53.0) | [![OpenSSF Scorecard](https://api.securityscorecards.dev/projects/github.com/typescript-eslint/typescript-eslint/badge)](https://securityscorecards.dev/viewer/?uri=github.com/typescript-eslint/typescript-eslint) | | [react-router-dom](https://github.com/remix-run/react-router) ([source](https://github.com/remix-run/react-router/tree/HEAD/packages/react-router-dom)) | dependencies | minor | [`7.11.0` → `7.12.0`](https://renovatebot.com/diffs/npm/react-router-dom/7.11.0/7.12.0) | [![OpenSSF Scorecard](https://api.securityscorecards.dev/projects/github.com/remix-run/react-router/badge)](https://securityscorecards.dev/viewer/?uri=github.com/remix-run/react-router) | --- ### Release Notes <details> <summary>mui/mui-x (@mui/x-charts)</summary> ### [`v8.24.0`](https://github.com/mui/mui-x/blob/HEAD/CHANGELOG.md#8240) [Compare Source](mui/mui-x@v8.23.0...v8.24.0) *Jan 8, 2026* We'd like to extend a big thank you to the 12 contributors who made this release possible. Here are some highlights ✨: - ⚡️Add bar [batch renderer](https://mui.com/x/react-charts/bars/#performance), result in a significant performance improvement when rendering thousands of bars - 📊 Add [range bar chart](https://mui.com/x/react-charts/range-bar/) to render ![image](https://github.com/user-attachments/assets/4112c09b-d841-42f7-a0c8-d23b61c23ca0) - 🌎 Improved Danish (da-DK) and Japanese (ja-JP) locales on the Data Grid Special thanks go out to these community members for their valuable contributions: [@anders-noerrelykke](https://github.com/anders-noerrelykke), [@auloin](https://github.com/auloin), [@sai6855](https://github.com/sai6855), [@yuito-it](https://github.com/yuito-it) The following team members contributed to this release: [@alelthomas](https://github.com/alelthomas), [@alexfauquette](https://github.com/alexfauquette), [@arminmeh](https://github.com/arminmeh), [@bernardobelchior](https://github.com/bernardobelchior), [@flaviendelangle](https://github.com/flaviendelangle), [@JCQuintas](https://github.com/JCQuintas), [@mapache-salvaje](https://github.com/mapache-salvaje), [@siriwatknp](https://github.com/siriwatknp) ##### Data Grid ##### `@mui/x-data-grid@8.24.0` - \[l10n] Improve Danish (da-DK) locale ([#20828](mui/mui-x#20828)) [@anders-noerrelykke](https://github.com/anders-noerrelykke) - \[l10n] Improve Japanese (ja-JP) locale ([#20251](mui/mui-x#20251)) [@yuito-it](https://github.com/yuito-it) ##### `@mui/x-data-grid-pro@8.24.0` [![pro](https://mui.com/r/x-pro-svg)](https://mui.com/r/x-pro-svg-link "Pro plan") Same changes as in `@mui/x-data-grid@8.24.0`, plus: - \[DataGridPro] Fix header filter height for `density="compact"` ([#20834](mui/mui-x#20834)) [@arminmeh](https://github.com/arminmeh) ##### `@mui/x-data-grid-premium@8.24.0` [![premium](https://mui.com/r/x-premium-svg)](https://mui.com/r/x-premium-svg-link "Premium plan") Same changes as in `@mui/x-data-grid-pro@8.24.0`. ##### Date and Time Pickers ##### `@mui/x-date-pickers@8.24.0` - \[pickers] Fix Styles applied to PickersDay when MuiPickersDay-dayOutsideMonth is used ([#20719](mui/mui-x#20719)) [@sai6855](https://github.com/sai6855) ##### `@mui/x-date-pickers-pro@8.24.0` [![pro](https://mui.com/r/x-pro-svg)](https://mui.com/r/x-pro-svg-link "Pro plan") Same changes as in `@mui/x-date-pickers@8.24.0`. ##### Charts ##### `@mui/x-charts@8.24.0` - \[charts] Add `VisibilityManager` logic to allow managing series/items ([#20571](mui/mui-x#20571)) [@JCQuintas](https://github.com/JCQuintas) - \[charts] Add `identifierSerializer` configuration ([#20775](mui/mui-x#20775)) [@JCQuintas](https://github.com/JCQuintas) - \[charts] Add `serializeIdentifier` instance function ([#20791](mui/mui-x#20791)) [@JCQuintas](https://github.com/JCQuintas) - \[charts] Add bar batch renderer ([#20457](mui/mui-x#20457)) [@bernardobelchior](https://github.com/bernardobelchior) - \[charts] Allow animating bar, line, and pie elements to hidden state ([#20798](mui/mui-x#20798)) [@JCQuintas](https://github.com/JCQuintas) - \[charts] Fix failing lint step ([#20813](mui/mui-x#20813)) [@bernardobelchior](https://github.com/bernardobelchior) - \[charts] Fix tooltip anchored to item ([#20783](mui/mui-x#20783)) [@alexfauquette](https://github.com/alexfauquette) - \[charts] Fix type casting in getCategoryAxisConfig and applySeriesLayout functions ([#20797](mui/mui-x#20797)) [@sai6855](https://github.com/sai6855) - \[charts] Let keyboard navigation avoid overflow and handle nullish values ([#20757](mui/mui-x#20757)) [@alexfauquette](https://github.com/alexfauquette) - \[charts] Refactor `PieChart` and `PieChartPro` to use `slots` and `slotProps` directly ([#20795](mui/mui-x#20795)) [@sai6855](https://github.com/sai6855) - \[charts] Refactor `useRegisterPointerEventHandlers` ([#20824](mui/mui-x#20824)) [@bernardobelchior](https://github.com/bernardobelchior) - \[charts] Update legend types to allow hiding/showing items ([#20784](mui/mui-x#20784)) [@JCQuintas](https://github.com/JCQuintas) ##### `@mui/x-charts-pro@8.24.0` [![pro](https://mui.com/r/x-pro-svg)](https://mui.com/r/x-pro-svg-link "Pro plan") Same changes as in `@mui/x-charts@8.24.0`, plus: - \[charts-pro] Pass `slotProps.toolbar` to `Toolbar` in `PieChartPro` ([#20796](mui/mui-x#20796)) [@sai6855](https://github.com/sai6855) ##### `@mui/x-charts-premium@8.24.0` [![premium](https://mui.com/r/x-premium-svg)](https://mui.com/r/x-premium-svg-link "Premium plan") Same changes as in `@mui/x-charts-pro@8.24.0`, plus: - \[charts-premium] Add range bar chart ([#20275](mui/mui-x#20275)) [@bernardobelchior](https://github.com/bernardobelchior) ##### Tree View ##### `@mui/x-tree-view@8.24.0` - \[tree view] Introduce a Tree View Store to clean the internals ([#20051](mui/mui-x#20051)) [@flaviendelangle](https://github.com/flaviendelangle) ##### `@mui/x-tree-view-pro@8.24.0` [![pro](https://mui.com/r/x-pro-svg)](https://mui.com/r/x-pro-svg-link "Pro plan") Same changes as in `@mui/x-tree-view@8.24.0`. ##### Codemod ##### `@mui/x-codemod@8.24.0` Internal changes. ##### Docs - \[docs] Fix axis size default values ([#20799](mui/mui-x#20799)) [@bernardobelchior](https://github.com/bernardobelchior) - \[docs] Update What's New in MUI X page with post v8 features (DX-118) ([#20787](mui/mui-x#20787)) [@alelthomas](https://github.com/alelthomas) - \[docs] Fix `onAccept`'s `context.source` documentation to use 'view' instead of 'picker' ([#20465](mui/mui-x#20465)) [@auloin](https://github.com/auloin) - \[docs] Revise the Charts Brush doc ([#20792](mui/mui-x#20792)) [@mapache-salvaje](https://github.com/mapache-salvaje) - \[docs] Revise the Charts Highlighting doc ([#20788](mui/mui-x#20788)) [@mapache-salvaje](https://github.com/mapache-salvaje) - \[docs] Revise the Charts Label doc ([#20794](mui/mui-x#20794)) [@mapache-salvaje](https://github.com/mapache-salvaje) - \[docs] Revise the Charts Export doc ([#20779](mui/mui-x#20779)) [@mapache-salvaje](https://github.com/mapache-salvaje) ##### Core - \[code-infra] Fix v8.23.0 release date ([#20767](mui/mui-x#20767)) [@bernardobelchior](https://github.com/bernardobelchior) - \[code-infra] Remove `glob-gitignore` ([#20801](mui/mui-x#20801)) [@bernardobelchior](https://github.com/bernardobelchior) - \[code-infra] Remove `nyc` ([#20804](mui/mui-x#20804)) [@bernardobelchior](https://github.com/bernardobelchior) - \[code-infra] Remove `stream-browserify` and `null-loader` ([#20805](mui/mui-x#20805)) [@bernardobelchior](https://github.com/bernardobelchior) - \[code-infra] Remove `stylelint-config-tailwindcss` ([#20807](mui/mui-x#20807)) [@bernardobelchior](https://github.com/bernardobelchior) - \[code-infra] Remove unused `path` package ([#20802](mui/mui-x#20802)) [@bernardobelchior](https://github.com/bernardobelchior) - \[code-infra] Retry flaky e2e test on webkit ([#20806](mui/mui-x#20806)) [@JCQuintas](https://github.com/JCQuintas) - \[internal] Add `internal` slot to properly generate components CSS layer ([#20763](mui/mui-x#20763)) [@siriwatknp](https://github.com/siriwatknp) </details> <details> <summary>OpenAPITools/openapi-generator-cli (@openapitools/openapi-generator-cli)</summary> ### [`v2.27.0`](https://github.com/OpenAPITools/openapi-generator-cli/releases/tag/v2.27.0) [Compare Source](OpenAPITools/openapi-generator-cli@v2.26.0...v2.27.0) ##### Features - **config:** add support for environment variable placeholders in config ([#1031](OpenAPITools/openapi-generator-cli#1031)) ([1cd2614](OpenAPITools/openapi-generator-cli@1cd2614)) </details> <details> <summary>typescript-eslint/typescript-eslint (@typescript-eslint/eslint-plugin)</summary> ### [`v8.53.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8530-2026-01-12) [Compare Source](typescript-eslint/typescript-eslint@v8.52.0...v8.53.0) ##### 🚀 Features - **eslint-plugin:** add rule \[strict-void-return] ([#9707](typescript-eslint/typescript-eslint#9707)) - **eslint-plugin:** \[no-unused-vars] add a fixer to remove unused imports ([#11922](typescript-eslint/typescript-eslint#11922)) ##### 🩹 Fixes - **eslint-plugin:** \[no-useless-default-assignment] fix false positive for parameters corresponding to a rest parameter ([#11916](typescript-eslint/typescript-eslint#11916)) - **eslint-plugin:** replace unclear "`error` typed" with more helpful description ([#11704](typescript-eslint/typescript-eslint#11704)) - **typescript-estree:** forbid invalid `extends` and `implements` in interface declaration ([#11935](typescript-eslint/typescript-eslint#11935)) - **typescript-estree:** forbid invalid class implements ([#11934](typescript-eslint/typescript-eslint#11934)) - **typescript-estree:** forbid type-only import with both default and named specifiers ([#11930](typescript-eslint/typescript-eslint#11930)) ##### ❤️ Thank You - Brad Zacher [@bradzacher](https://github.com/bradzacher) - fisker Cheung [@fisker](https://github.com/fisker) - Josh Goldberg - Josh Goldberg ✨ - Kirk Waiblinger - Niki [@phaux](https://github.com/phaux) - Nikita - SungHyun627 [@SungHyun627](https://github.com/SungHyun627) - Will Harney [@wjhsf](https://github.com/wjhsf) You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website. ### [`v8.52.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8520-2026-01-05) [Compare Source](typescript-eslint/typescript-eslint@v8.51.0...v8.52.0) ##### 🚀 Features - **eslint-plugin-internal:** \[no-multiple-lines-of-errors] add rule ([#11899](typescript-eslint/typescript-eslint#11899)) ##### 🩹 Fixes - **eslint-plugin:** \[no-base-to-string] detect @[@toPrimitive](https://github.com/toPrimitive) and valueOf ([#11901](typescript-eslint/typescript-eslint#11901)) - **eslint-plugin:** \[no-useless-default-assignment] handle conditional initializer ([#11908](typescript-eslint/typescript-eslint#11908)) ##### ❤️ Thank You - Josh Goldberg ✨ - Ulrich Stark You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website. </details> <details> <summary>typescript-eslint/typescript-eslint (@typescript-eslint/parser)</summary> ### [`v8.53.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#8530-2026-01-12) [Compare Source](typescript-eslint/typescript-eslint@v8.52.0...v8.53.0) This was a version bump only for parser to align it with other projects, there were no code changes. You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website. ### [`v8.52.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#8520-2026-01-05) [Compare Source](typescript-eslint/typescript-eslint@v8.51.0...v8.52.0) This was a version bump only for parser to align it with other projects, there were no code changes. You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website. </details> <details> <summary>remix-run/react-router (react-router-dom)</summary> ### [`v7.12.0`](https://github.com/remix-run/react-router/blob/HEAD/packages/react-router-dom/CHANGELOG.md#7120) [Compare Source](https://github.com/remix-run/react-router/compare/react-router-dom@7.11.0...react-router-dom@7.12.0) ##### Patch Changes - Updated dependencies: - `react-router@7.12.0` </details> --- - [ ] If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  See merge request swiss-armed-forces/cyber-command/cea/loom!243 Co-authored-by: Loom MR Pipeline Trigger <group_103951964_bot_9504bb8dead6d4e406ad817a607f24be@noreply.gitlab.com> Co-authored-by: open-source Pipeline <group_90701827_bot_ed04ae348bc5f40af9966fb8b6867e99@noreply.gitlab.com>

fix(eslint-plugin): [no-base-to-string] detect @@toPrimitive and valueOf

beb89c8

JoshuaKGoldberg marked this pull request as ready for review December 29, 2025 18:58

One more test, toValueOf

f33472f

bradzacher approved these changes Jan 5, 2026

View reviewed changes

bradzacher added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Jan 5, 2026

JoshuaKGoldberg merged commit 309a38e into typescript-eslint:main Jan 5, 2026
69 checks passed

chrisbbreuer mentioned this pull request Jan 3, 2026

chore(deps): update all non-major dependencies stacksjs/eslint-plugin#67

Closed

1 task

ArnaudBarre added a commit to ArnaudBarre/tsl that referenced this pull request Feb 1, 2026

Port typescript-eslint/typescript-eslint#11901

7d66a7e

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(eslint-plugin): [no-base-to-string] detect @@toPrimitive and valueOf#11901

fix(eslint-plugin): [no-base-to-string] detect @@toPrimitive and valueOf#11901
JoshuaKGoldberg merged 2 commits intotypescript-eslint:mainfrom
JoshuaKGoldberg:no-base-to-string-toPrimitive-valueOf

JoshuaKGoldberg commented Dec 29, 2025 •

edited

Loading

Uh oh!

typescript-eslint bot commented Dec 29, 2025

Uh oh!

netlify bot commented Dec 29, 2025 •

edited

Loading

Uh oh!

nx-cloud bot commented Dec 29, 2025 •

edited

Loading

Uh oh!

codecov bot commented Dec 29, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

JoshuaKGoldberg commented Dec 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Checklist

Overview

Uh oh!

typescript-eslint bot commented Dec 29, 2025

Uh oh!

netlify bot commented Dec 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for typescript-eslint ready!

Uh oh!

nx-cloud bot commented Dec 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Dec 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

JoshuaKGoldberg commented Dec 29, 2025 •

edited

Loading

netlify bot commented Dec 29, 2025 •

edited

Loading

nx-cloud bot commented Dec 29, 2025 •

edited

Loading

codecov bot commented Dec 29, 2025 •

edited

Loading