Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: tweak grammar #1227

Merged
merged 1 commit into from Nov 19, 2019
Merged

docs: tweak grammar #1227

merged 1 commit into from Nov 19, 2019

Conversation

@jergason
Copy link
Contributor

jergason commented Nov 19, 2019

"comprised of" is incorrect, since "comprise" means "to include" and refers to the whole, not the parts. Change "comprised of" to "composed of". See https://www.dictionary.com/e/comprise-vs-compose/ for an explanation.

"comprised of" is incorrect, since "comprise" means "to include" and refers to the whole, not the parts. Change "comprised of" to "composed of". See https://www.dictionary.com/e/comprise-vs-compose/ for an explanation.
@typescript-eslint

This comment has been minimized.

Copy link

typescript-eslint bot commented Nov 19, 2019

Thanks for the PR, @jergason!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@bradzacher bradzacher changed the title comprised of -> composed of docs: tweak grammar Nov 19, 2019
@bradzacher bradzacher merged commit 4550015 into typescript-eslint:master Nov 19, 2019
7 checks passed
7 checks passed
Semantic Pull Request ready to be squashed
Details
codecov/patch Coverage not affected when comparing 2b3b5d6...ca09690
Details
codecov/project 94.23% remains the same compared to 2b3b5d6
Details
typescript-eslint.typescript-eslint #20191119.1 succeeded
Details
typescript-eslint.typescript-eslint (Primary code validation and tests) Primary code validation and tests succeeded
Details
typescript-eslint.typescript-eslint (Run unit tests on other Node.js versions node_10_x) Run unit tests on other Node.js versions node_10_x succeeded
Details
typescript-eslint.typescript-eslint (Run unit tests on other Node.js versions node_8_x) Run unit tests on other Node.js versions node_8_x succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.