Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint-plugin): [no-empty-function] add missed node types #1271

Merged

Conversation

@typescript-eslint

This comment has been minimized.

Copy link

typescript-eslint bot commented Nov 27, 2019

Thanks for the PR, @a-tarasyuk!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@a-tarasyuk a-tarasyuk force-pushed the a-tarasyuk:bug/add-missed-node-types branch from 828cae7 to afe9069 Nov 27, 2019
Copy link
Member

bradzacher left a comment

Thanks for this. One change, otherwise LGTM

@a-tarasyuk a-tarasyuk force-pushed the a-tarasyuk:bug/add-missed-node-types branch from afe9069 to e75c560 Nov 27, 2019
@a-tarasyuk a-tarasyuk requested a review from bradzacher Nov 27, 2019
Copy link
Member

bradzacher left a comment

LGTM - thanks

@bradzacher bradzacher merged commit e9d44f5 into typescript-eslint:master Nov 27, 2019
7 checks passed
7 checks passed
Semantic Pull Request ready to be squashed
Details
codecov/patch Coverage not affected when comparing 3b931ac...e75c560
Details
codecov/project 94.06% (-0.01%) compared to 3b931ac
Details
typescript-eslint.typescript-eslint #20191127.7 succeeded
Details
typescript-eslint.typescript-eslint (Primary code validation and tests) Primary code validation and tests succeeded
Details
typescript-eslint.typescript-eslint (Run unit tests on other Node.js versions node_10_x) Run unit tests on other Node.js versions node_10_x succeeded
Details
typescript-eslint.typescript-eslint (Run unit tests on other Node.js versions node_8_x) Run unit tests on other Node.js versions node_8_x succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.