Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(eslint-plugin): typo in space-before-function-paren docs #1297

Merged
merged 1 commit into from Dec 2, 2019

Conversation

@BO41
Copy link
Contributor

BO41 commented Dec 2, 2019

This lint is about the space after function but in the example both versions do have one.
The eslint page has it like this

function withoutSpace(x) { // <-- NO space
    // ...
}

function withSpace (x) { // <-- space
    // ...
}

var anonymousWithoutSpace = function() {};

var anonymousWithSpace = function () {};
@typescript-eslint

This comment has been minimized.

Copy link

typescript-eslint bot commented Dec 2, 2019

Thanks for the PR, @BO41!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

Copy link
Member

bradzacher left a comment

thanks for this

@bradzacher bradzacher changed the title Remove space in space-before-function-paren docs(eslint-plugin): typo in space-before-function-paren docs Dec 2, 2019
@bradzacher bradzacher merged commit 5362561 into typescript-eslint:master Dec 2, 2019
7 checks passed
7 checks passed
Semantic Pull Request ready to be squashed
Details
codecov/patch Coverage not affected when comparing 5adb8a2...80985d2
Details
codecov/project 94.01% remains the same compared to 5adb8a2
Details
typescript-eslint.typescript-eslint #20191202.7 succeeded
Details
typescript-eslint.typescript-eslint (Primary code validation and tests) Primary code validation and tests succeeded
Details
typescript-eslint.typescript-eslint (Run unit tests on other Node.js versions node_10_x) Run unit tests on other Node.js versions node_10_x succeeded
Details
typescript-eslint.typescript-eslint (Run unit tests on other Node.js versions node_8_x) Run unit tests on other Node.js versions node_8_x succeeded
Details
@BO41 BO41 deleted the BO41:patch-1 branch Dec 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.