Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: migrate lodash from function packages #1430

Merged
merged 1 commit into from Jan 12, 2020

Conversation

@armano2
Copy link
Member

armano2 commented Jan 11, 2020

This PR migrates our usages of lodash.* standalone per method packages to single module.

Why?
Other projects started moving out of standalone per method packages in favor of single module (eg. babel)

However, use of these packages is discouraged and they will be removed in v5.
https://lodash.com/per-method-packages

fixes #1399

@typescript-eslint

This comment was marked as resolved.

Copy link

typescript-eslint bot commented Jan 11, 2020

Thanks for the PR, @armano2!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@armano2 armano2 self-assigned this Jan 11, 2020
@codecov

This comment has been minimized.

Copy link

codecov bot commented Jan 11, 2020

Codecov Report

Merging #1430 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master    #1430   +/-   ##
=======================================
  Coverage   94.48%   94.48%           
=======================================
  Files         142      142           
  Lines        6077     6077           
  Branches     1726     1726           
=======================================
  Hits         5742     5742           
  Misses        182      182           
  Partials      153      153
Impacted Files Coverage Δ
packages/eslint-plugin-tslint/src/rules/config.ts 100% <100%> (ø) ⬆️
packages/typescript-estree/src/node-utils.ts 96.98% <100%> (ø) ⬆️
Copy link
Member

bradzacher left a comment

sure, I'm okay with this!

@bradzacher bradzacher merged commit c69e402 into typescript-eslint:master Jan 12, 2020
7 checks passed
7 checks passed
Semantic Pull Request ready to be squashed
Details
codecov/patch 100% of diff hit (target 90%)
Details
codecov/project 94.48% (+0%) compared to a37ff9f
Details
typescript-eslint.typescript-eslint Build #20200111.7 succeeded
Details
typescript-eslint.typescript-eslint (Primary code validation and tests) Primary code validation and tests succeeded
Details
typescript-eslint.typescript-eslint (Run unit tests on other Node.js versions node_10_x) Run unit tests on other Node.js versions node_10_x succeeded
Details
typescript-eslint.typescript-eslint (Run unit tests on other Node.js versions node_8_x) Run unit tests on other Node.js versions node_8_x succeeded
Details
@armano2 armano2 deleted the armano2:lodash-migrate branch Jan 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.