chore: upgrade husky and lint-staged

[ikeryo1182]

This PR upgrades version of husky and lint-staged

[armano2]

can you update message to conventional commits standard

• https://www.conventionalcommits.org/en/

[JamesHenry]

I'm not sure this is working, I just pulled your branch, yarn installed and tried to commit with "TEST ME", and it succeeded:

✔ Running linters...
[pr/ikeryo1182/144 22e2070] TEST ME

That should have failed commit message validation.

Please can you verify that there is no change in behaviour before and after this PR?

[JamesHenry]

I'm not sure this is working, I just pulled your branch, yarn installed and tried to commit with "TEST ME", and it succeeded:

✔ Running linters...
[pr/ikeryo1182/144 22e2070] TEST ME

That should have failed commit message validation.

Please can you verify that there is no change in behaviour before and after this PR?

[armano2]

thats weird, its working on windows, maybe there is issues with mac only?

[JamesHenry]

I will try a completely fresh install

[JamesHenry]

Nuked all my node_modules and ran lerna clean, same result:

→ git commit -m 'does the hook work?'
husky > pre-commit (node v8.12.0)
yarn run v1.12.3
$ lerna run test --parallel
lerna notice cli v3.10.5
lerna info Executing command in 4 packages: "yarn run test"
@typescript-eslint/eslint-plugin-tslint: $ jest --coverage
@typescript-eslint/eslint-plugin: $ jest --coverage
@typescript-eslint/typescript-estree: $ jest --coverage
@typescript-eslint/parser: $ jest --coverage
@typescript-eslint/eslint-plugin: PASS tests/lib/rules/no-var-requires.js (5.351s)
@typescript-eslint/eslint-plugin: PASS tests/lib/rules/indent.js
@typescript-eslint/eslint-plugin: PASS tests/lib/rules/type-annotation-spacing.js (9.806s)
@typescript-eslint/parser: PASS tests/lib/typescript.ts (9.978s)
@typescript-eslint/parser: PASS tests/lib/javascript.ts (11.146s)
@typescript-eslint/eslint-plugin: PASS tests/lib/rules/no-unused-vars.js
@typescript-eslint/typescript-estree: PASS tests/lib/semantic-diagnostics-enabled.ts (12.965s)
@typescript-eslint/eslint-plugin: PASS tests/lib/rules/member-ordering.js
@typescript-eslint/parser: PASS tests/lib/tsx.ts
@typescript-eslint/eslint-plugin: PASS tests/lib/rules/member-delimiter-style.js
@typescript-eslint/parser: PASS tests/lib/scope-analysis.ts
@typescript-eslint/eslint-plugin: PASS tests/lib/rules/no-type-alias.js
@typescript-eslint/parser: PASS tests/lib/services.ts (6.913s)
@typescript-eslint/eslint-plugin: PASS tests/lib/rules/array-type.js
@typescript-eslint/typescript-estree: PASS tests/ast-alignment/spec.ts (17.214s)
@typescript-eslint/parser: PASS tests/lib/jsx.ts
@typescript-eslint/eslint-plugin: PASS tests/lib/rules/adjacent-overload-signatures.js
@typescript-eslint/eslint-plugin: PASS tests/lib/rules/no-explicit-any.js
@typescript-eslint/parser: PASS tests/lib/comments.ts
@typescript-eslint/parser: PASS tests/lib/parser.ts (19.199s)
@typescript-eslint/eslint-plugin: PASS tests/lib/eslint-rules/no-undef.js
@typescript-eslint/typescript-estree: PASS tests/lib/javascript.ts (6.16s)
@typescript-eslint/parser: PASS tests/lib/basics.ts
@typescript-eslint/eslint-plugin: PASS tests/lib/rules/no-use-before-define.js
@typescript-eslint/typescript-estree: PASS tests/lib/comments.ts
@typescript-eslint/eslint-plugin: PASS tests/lib/rules/no-parameter-properties.js
@typescript-eslint/eslint-plugin: PASS tests/lib/rules/generic-type-naming.js
@typescript-eslint/eslint-plugin: PASS tests/lib/rules/no-angle-bracket-type-assertion.js
@typescript-eslint/typescript-estree: PASS tests/lib/jsx.ts
@typescript-eslint/eslint-plugin: PASS tests/lib/rules/no-inferrable-types.js
@typescript-eslint/typescript-estree: PASS tests/lib/typescript.ts
@typescript-eslint/typescript-estree: PASS tests/lib/parse.ts
@typescript-eslint/eslint-plugin: PASS tests/lib/rules/ban-types.js
@typescript-eslint/typescript-estree: PASS tests/lib/tsx.ts
@typescript-eslint/typescript-estree: PASS tests/lib/semanticInfo.ts (23.044s)
@typescript-eslint/eslint-plugin: PASS tests/lib/rules/no-extraneous-class.js
@typescript-eslint/eslint-plugin: PASS tests/lib/rules/camelcase.js
@typescript-eslint/parser: =============================== Coverage summary ===============================
@typescript-eslint/parser: Statements   : 97.89% ( 278/284 )
@typescript-eslint/parser: Branches     : 90.35% ( 103/114 )
@typescript-eslint/parser: Functions    : 98.36% ( 60/61 )
@typescript-eslint/parser: Lines        : 97.88% ( 277/283 )
@typescript-eslint/parser: ================================================================================
@typescript-eslint/eslint-plugin: PASS tests/lib/rules/no-object-literal-type-assertion.js
@typescript-eslint/parser: Test Suites: 9 passed, 9 total
@typescript-eslint/parser: Tests:       884 passed, 884 total
@typescript-eslint/parser: Snapshots:   872 passed, 872 total
@typescript-eslint/parser: Time:        25.22s, estimated 40s
@typescript-eslint/parser: Ran all test suites.
@typescript-eslint/eslint-plugin: PASS tests/lib/rules/no-array-constructor.js
@typescript-eslint/eslint-plugin: PASS tests/lib/rules/no-namespace.js
@typescript-eslint/eslint-plugin: PASS tests/lib/rules/no-misused-new.js
@typescript-eslint/eslint-plugin: PASS tests/lib/rules/explicit-function-return-type.js
@typescript-eslint/eslint-plugin: PASS tests/lib/rules/no-this-alias.js
@typescript-eslint/eslint-plugin: PASS tests/lib/rules/member-naming.js
@typescript-eslint/eslint-plugin: PASS tests/lib/eslint-rules/strict.js
@typescript-eslint/typescript-estree: =============================== Coverage summary ===============================
@typescript-eslint/typescript-estree: Statements   : 96.62% ( 1229/1272 )
@typescript-eslint/typescript-estree: Branches     : 93.3% ( 877/940 )
@typescript-eslint/typescript-estree: Functions    : 95.15% ( 98/103 )
@typescript-eslint/typescript-estree: Lines        : 96.61% ( 1227/1270 )
@typescript-eslint/typescript-estree: ================================================================================
@typescript-eslint/eslint-plugin: PASS tests/lib/rules/explicit-member-accessibility.js
@typescript-eslint/eslint-plugin-tslint: PASS tests/index.spec.ts (27.705s)
@typescript-eslint/eslint-plugin-tslint:   tslint/config
@typescript-eslint/eslint-plugin-tslint:     valid
@typescript-eslint/eslint-plugin-tslint:       ✓ var foo = true; (11178ms)
@typescript-eslint/eslint-plugin-tslint:       ✓ import { x } from './file'; console.assert(x);  (3159ms)
@typescript-eslint/eslint-plugin-tslint:       ✓ throw "should be ok because rule is not loaded"; (1804ms)
@typescript-eslint/eslint-plugin-tslint:     invalid
@typescript-eslint/eslint-plugin-tslint:       ✓ throw "err" // no-string-throw (2123ms)
@typescript-eslint/eslint-plugin-tslint:       ✓ var foo = true // semicolon (1409ms)
@typescript-eslint/eslint-plugin-tslint:       ✓ var foo = true // fail (1158ms)
@typescript-eslint/eslint-plugin-tslint:       ✓ const a: string = 1; const sum = 1 + '2';  (10ms)
@typescript-eslint/typescript-estree: Test Suites: 9 passed, 9 total
@typescript-eslint/typescript-estree: Tests:       2209 passed, 2209 total
@typescript-eslint/typescript-estree: Snapshots:   1494 passed, 1494 total
@typescript-eslint/typescript-estree: Time:        27.921s, estimated 51s
@typescript-eslint/typescript-estree: Ran all test suites.
@typescript-eslint/eslint-plugin: PASS tests/lib/rules/class-name-casing.js
@typescript-eslint/eslint-plugin: PASS tests/lib/rules/no-non-null-assertion.js
@typescript-eslint/eslint-plugin-tslint: =============================== Coverage summary ===============================
@typescript-eslint/eslint-plugin-tslint: Statements   : 97.14% ( 34/35 )
@typescript-eslint/eslint-plugin-tslint: Branches     : 87.5% ( 14/16 )
@typescript-eslint/eslint-plugin-tslint: Functions    : 100% ( 7/7 )
@typescript-eslint/eslint-plugin-tslint: Lines        : 97.14% ( 34/35 )
@typescript-eslint/eslint-plugin-tslint: ================================================================================
@typescript-eslint/eslint-plugin: PASS tests/lib/rules/no-triple-slash-reference.js
@typescript-eslint/eslint-plugin-tslint: Test Suites: 1 passed, 1 total
@typescript-eslint/eslint-plugin-tslint: Tests:       7 passed, 7 total
@typescript-eslint/eslint-plugin-tslint: Snapshots:   0 total
@typescript-eslint/eslint-plugin-tslint: Time:        28.592s, estimated 47s
@typescript-eslint/eslint-plugin-tslint: Ran all test suites.
@typescript-eslint/eslint-plugin: PASS tests/lib/eslint-rules/no-unused-vars.js
@typescript-eslint/eslint-plugin: PASS tests/lib/rules/interface-name-prefix.js
@typescript-eslint/eslint-plugin: PASS tests/lib/eslint-rules/no-shadow.js
@typescript-eslint/eslint-plugin: PASS tests/lib/eslint-rules/no-use-before-define.js
@typescript-eslint/eslint-plugin: PASS tests/lib/eslint-rules/no-dupe-args.js
@typescript-eslint/eslint-plugin: PASS tests/lib/rules/prefer-interface.js
@typescript-eslint/eslint-plugin: PASS tests/lib/eslint-rules/no-restricted-globals.js
@typescript-eslint/eslint-plugin: PASS tests/lib/rules/no-empty-interface.js
@typescript-eslint/eslint-plugin: PASS tests/lib/rules/prefer-namespace-keyword.js
@typescript-eslint/eslint-plugin: PASS tests/lib/eslint-rules/no-implicit-globals.js
@typescript-eslint/eslint-plugin: PASS tests/lib/eslint-rules/no-redeclare.js
@typescript-eslint/eslint-plugin: PASS tests/lib/util.js
@typescript-eslint/eslint-plugin: PASS tests/lib/rules/restrict-plus-operands.js (38.467s)
@typescript-eslint/eslint-plugin: =============================== Coverage summary ===============================
@typescript-eslint/eslint-plugin: Statements   : 97.38% ( 781/802 )
@typescript-eslint/eslint-plugin: Branches     : 92.94% ( 632/680 )
@typescript-eslint/eslint-plugin: Functions    : 100% ( 98/98 )
@typescript-eslint/eslint-plugin: Lines        : 97.59% ( 769/788 )
@typescript-eslint/eslint-plugin: ================================================================================
@typescript-eslint/eslint-plugin: Test Suites: 44 passed, 44 total
@typescript-eslint/eslint-plugin: Tests:       1763 passed, 1763 total
@typescript-eslint/eslint-plugin: Snapshots:   0 total
@typescript-eslint/eslint-plugin: Time:        40.284s, estimated 65s
@typescript-eslint/eslint-plugin: Ran all test suites.
lerna success run Ran npm script 'test' in 4 packages in 42.3s:
lerna success - @typescript-eslint/eslint-plugin-tslint
lerna success - @typescript-eslint/eslint-plugin
lerna success - @typescript-eslint/parser
lerna success - @typescript-eslint/typescript-estree
✨  Done in 43.45s.
  ↓ Stashing changes... [skipped]
    → No partially staged files found...
  ✔ Running linters...
[pr/ikeryo1182/144 b7f4892] does the hook work?

I tried on both a .md and a .ts file

[ikeryo1182]

I tried with the following changes and then it seems to have worked well on Mac.

- "commitmsg": "commitlint -E GIT_PARAMS"
+ "commit-msg": "commitlint -E HUSKY_GIT_PARAMS"

result:

→ git commit -m "TEST COMMITLINT"
husky > pre-commit (node v10.8.0)
yarn run v1.10.0
$ lerna run test --parallel
lerna notice cli v3.10.5
lerna info Executing command in 4 packages: "yarn run test"
@typescript-eslint/eslint-plugin-tslint: $ jest --coverage
@typescript-eslint/eslint-plugin: $ jest --coverage
@typescript-eslint/parser: $ jest --coverage
@typescript-eslint/typescript-estree: $ jest --coverage
@typescript-eslint/typescript-estree: PASS tests/lib/comments.ts (8.448s)
@typescript-eslint/typescript-estree: PASS tests/lib/jsx.ts (8.501s)
@typescript-eslint/parser: PASS tests/lib/scope-analysis.ts (9.717s)
@typescript-eslint/typescript-estree: PASS tests/lib/tsx.ts
@typescript-eslint/typescript-estree: PASS tests/lib/parse.ts
@typescript-eslint/eslint-plugin: PASS tests/lib/rules/no-type-alias.js (10.816s)
@typescript-eslint/eslint-plugin: PASS tests/lib/rules/member-delimiter-style.js (10.756s)
@typescript-eslint/parser: PASS tests/lib/basics.ts (11.194s)
@typescript-eslint/eslint-plugin: PASS tests/lib/rules/no-unused-vars.js (11.554s)
@typescript-eslint/parser: PASS tests/lib/tsx.ts (11.611s)
@typescript-eslint/parser: PASS tests/lib/comments.ts
@typescript-eslint/eslint-plugin: PASS tests/lib/rules/member-ordering.js (12.148s)
@typescript-eslint/eslint-plugin: PASS tests/lib/rules/indent.js (12.397s)
@typescript-eslint/parser: PASS tests/lib/jsx.ts
@typescript-eslint/eslint-plugin: PASS tests/lib/rules/adjacent-overload-signatures.js
@typescript-eslint/eslint-plugin: PASS tests/lib/rules/array-type.js
@typescript-eslint/eslint-plugin: PASS tests/lib/rules/no-use-before-define.js
@typescript-eslint/eslint-plugin: PASS tests/lib/rules/no-parameter-properties.js
@typescript-eslint/eslint-plugin: PASS tests/lib/rules/no-explicit-any.js
@typescript-eslint/typescript-estree: PASS tests/lib/typescript.ts (14.414s)
@typescript-eslint/eslint-plugin: PASS tests/lib/rules/type-annotation-spacing.js (15.197s)
@typescript-eslint/parser: PASS tests/lib/typescript.ts (15.215s)
@typescript-eslint/parser: PASS tests/lib/services.ts (15.273s)
@typescript-eslint/eslint-plugin: PASS tests/lib/rules/camelcase.js
@typescript-eslint/eslint-plugin: PASS tests/lib/rules/no-inferrable-types.js
@typescript-eslint/eslint-plugin: PASS tests/lib/rules/member-naming.js
@typescript-eslint/typescript-estree: PASS tests/lib/javascript.ts (16.006s)
@typescript-eslint/eslint-plugin: PASS tests/lib/rules/generic-type-naming.js
@typescript-eslint/eslint-plugin: PASS tests/lib/rules/explicit-function-return-type.js
@typescript-eslint/parser: PASS tests/lib/javascript.ts (16.382s)
@typescript-eslint/eslint-plugin: PASS tests/lib/rules/no-extraneous-class.js
@typescript-eslint/eslint-plugin: PASS tests/lib/rules/no-namespace.js
@typescript-eslint/eslint-plugin: PASS tests/lib/rules/prefer-namespace-keyword.js
@typescript-eslint/eslint-plugin: PASS tests/lib/rules/no-angle-bracket-type-assertion.js
@typescript-eslint/eslint-plugin: PASS tests/lib/rules/no-object-literal-type-assertion.js
@typescript-eslint/eslint-plugin: PASS tests/lib/rules/ban-types.js
@typescript-eslint/eslint-plugin: PASS tests/lib/rules/interface-name-prefix.js
@typescript-eslint/eslint-plugin: PASS tests/lib/rules/class-name-casing.js
@typescript-eslint/typescript-estree: PASS tests/lib/semantic-diagnostics-enabled.ts (18.235s)
@typescript-eslint/eslint-plugin: PASS tests/lib/rules/no-misused-new.js
@typescript-eslint/eslint-plugin: PASS tests/lib/rules/no-this-alias.js
@typescript-eslint/eslint-plugin: PASS tests/lib/rules/explicit-member-accessibility.js
@typescript-eslint/eslint-plugin: PASS tests/lib/rules/no-array-constructor.js
@typescript-eslint/eslint-plugin: PASS tests/lib/eslint-rules/no-restricted-globals.js
@typescript-eslint/eslint-plugin: PASS tests/lib/eslint-rules/no-undef.js
@typescript-eslint/eslint-plugin: PASS tests/lib/rules/prefer-interface.js
@typescript-eslint/eslint-plugin: PASS tests/lib/eslint-rules/no-use-before-define.js
@typescript-eslint/eslint-plugin: PASS tests/lib/eslint-rules/no-redeclare.js
@typescript-eslint/eslint-plugin: PASS tests/lib/rules/no-var-requires.js
@typescript-eslint/eslint-plugin: PASS tests/lib/rules/no-empty-interface.js
@typescript-eslint/eslint-plugin: PASS tests/lib/eslint-rules/strict.js
@typescript-eslint/eslint-plugin: PASS tests/lib/rules/no-triple-slash-reference.js
@typescript-eslint/eslint-plugin: PASS tests/lib/rules/no-non-null-assertion.js
@typescript-eslint/eslint-plugin: PASS tests/lib/eslint-rules/no-shadow.js
@typescript-eslint/eslint-plugin: PASS tests/lib/eslint-rules/no-unused-vars.js
@typescript-eslint/eslint-plugin: PASS tests/lib/util.js
@typescript-eslint/eslint-plugin: PASS tests/lib/eslint-rules/no-implicit-globals.js
@typescript-eslint/eslint-plugin: PASS tests/lib/eslint-rules/no-dupe-args.js
@typescript-eslint/typescript-estree: PASS tests/ast-alignment/spec.ts (21.785s)
@typescript-eslint/parser: PASS tests/lib/parser.ts (22.368s)
@typescript-eslint/typescript-estree: PASS tests/lib/semanticInfo.ts (24.661s)
@typescript-eslint/parser: =============================== Coverage summary ===============================
@typescript-eslint/parser: Statements   : 97.89% ( 278/284 )
@typescript-eslint/parser: Branches     : 90.35% ( 103/114 )
@typescript-eslint/parser: Functions    : 98.36% ( 60/61 )
@typescript-eslint/parser: Lines        : 97.88% ( 277/283 )
@typescript-eslint/parser: ================================================================================
@typescript-eslint/parser: Test Suites: 9 passed, 9 total
@typescript-eslint/parser: Tests:       884 passed, 884 total
@typescript-eslint/parser: Snapshots:   872 passed, 872 total
@typescript-eslint/parser: Time:        26.449s
@typescript-eslint/parser: Ran all test suites.
@typescript-eslint/eslint-plugin-tslint: PASS tests/index.spec.ts (27.908s)
@typescript-eslint/eslint-plugin-tslint:   tslint/config
@typescript-eslint/eslint-plugin-tslint:     valid
@typescript-eslint/eslint-plugin-tslint:       ✓ var foo = true; (11735ms)
@typescript-eslint/eslint-plugin-tslint:       ✓ import { x } from './file'; console.assert(x);  (1653ms)
@typescript-eslint/eslint-plugin-tslint:       ✓ throw "should be ok because rule is not loaded"; (1157ms)
@typescript-eslint/eslint-plugin-tslint:     invalid
@typescript-eslint/eslint-plugin-tslint:       ✓ throw "err" // no-string-throw (878ms)
@typescript-eslint/eslint-plugin-tslint:       ✓ var foo = true // semicolon (775ms)
@typescript-eslint/eslint-plugin-tslint:       ✓ var foo = true // fail (599ms)
@typescript-eslint/eslint-plugin-tslint:       ✓ const a: string = 1; const sum = 1 + '2';  (9ms)
@typescript-eslint/typescript-estree: =============================== Coverage summary ===============================
@typescript-eslint/typescript-estree: Statements   : 96.62% ( 1229/1272 )
@typescript-eslint/typescript-estree: Branches     : 93.3% ( 877/940 )
@typescript-eslint/typescript-estree: Functions    : 95.15% ( 98/103 )
@typescript-eslint/typescript-estree: Lines        : 96.61% ( 1227/1270 )
@typescript-eslint/typescript-estree: ================================================================================
@typescript-eslint/typescript-estree: Test Suites: 9 passed, 9 total
@typescript-eslint/typescript-estree: Tests:       2209 passed, 2209 total
@typescript-eslint/typescript-estree: Snapshots:   1494 passed, 1494 total
@typescript-eslint/typescript-estree: Time:        28.395s
@typescript-eslint/typescript-estree: Ran all test suites.
@typescript-eslint/eslint-plugin-tslint: =============================== Coverage summary ===============================
@typescript-eslint/eslint-plugin-tslint: Statements   : 97.14% ( 34/35 )
@typescript-eslint/eslint-plugin-tslint: Branches     : 87.5% ( 14/16 )
@typescript-eslint/eslint-plugin-tslint: Functions    : 100% ( 7/7 )
@typescript-eslint/eslint-plugin-tslint: Lines        : 97.14% ( 34/35 )
@typescript-eslint/eslint-plugin-tslint: ================================================================================
@typescript-eslint/eslint-plugin-tslint: Test Suites: 1 passed, 1 total
@typescript-eslint/eslint-plugin-tslint: Tests:       7 passed, 7 total
@typescript-eslint/eslint-plugin-tslint: Snapshots:   0 total
@typescript-eslint/eslint-plugin-tslint: Time:        28.654s
@typescript-eslint/eslint-plugin-tslint: Ran all test suites.
@typescript-eslint/eslint-plugin: PASS tests/lib/rules/restrict-plus-operands.js (37.422s)
@typescript-eslint/eslint-plugin: =============================== Coverage summary ===============================
@typescript-eslint/eslint-plugin: Statements   : 97.38% ( 781/802 )
@typescript-eslint/eslint-plugin: Branches     : 92.94% ( 632/680 )
@typescript-eslint/eslint-plugin: Functions    : 100% ( 98/98 )
@typescript-eslint/eslint-plugin: Lines        : 97.59% ( 769/788 )
@typescript-eslint/eslint-plugin: ================================================================================
@typescript-eslint/eslint-plugin: Test Suites: 44 passed, 44 total
@typescript-eslint/eslint-plugin: Tests:       1763 passed, 1763 total
@typescript-eslint/eslint-plugin: Snapshots:   0 total
@typescript-eslint/eslint-plugin: Time:        39.474s, estimated 40s
@typescript-eslint/eslint-plugin: Ran all test suites.
lerna success run Ran npm script 'test' in 4 packages in 41.1s:
lerna success - @typescript-eslint/eslint-plugin-tslint
lerna success - @typescript-eslint/eslint-plugin
lerna success - @typescript-eslint/parser
lerna success - @typescript-eslint/typescript-estree
✨  Done in 41.60s.
  ↓ Stashing changes... [skipped]
    → No partially staged files found...
  ✔ Running linters...
husky > commit-msg (node v10.8.0)

⧗   input:
TEST COMMITLINT

✖   subject may not be empty [subject-empty]
✖   type may not be empty [type-empty]
✖   found 2 problems, 0 warnings
    (Need help? -> https://github.com/marionebl/commitlint#what-is-commitlint)


husky > commit-msg hook failed (add --no-verify to bypass)

[JamesHenry]

@armano2 Does it still work for you on windows after the change?

[armano2]

i cleaned up node_modules and its working fine

most likely commitmsg was was working before due to some package cache (or bug).

[JamesHenry]

Works for me now too, thanks for contributing @ikeryo1182!