Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(typescript-estree): correct type of `ArrayPattern.elements` #1451

Merged
merged 1 commit into from Jan 14, 2020

Conversation

@bradzacher
Copy link
Member

bradzacher commented Jan 14, 2020

#1450 pointed out that the type is incorrect. The parser assigns null if the element in the pattern is empty, but the types were non-nullable.

@bradzacher bradzacher added the bug label Jan 14, 2020
@typescript-eslint

This comment has been minimized.

Copy link

typescript-eslint bot commented Jan 14, 2020

Thanks for the PR, @bradzacher!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@armano2

This comment has been minimized.

Copy link
Member

armano2 commented Jan 14, 2020

/home/vsts/work/1/s/packages/eslint-plugin/src/rules/indent-new-do-not-use/index.ts
  859:51  error  Prefer using nullish coalescing operator (`??`) instead of a logical or (`||`), as it is a safer operator  @typescript-eslint/prefer-nullish-coalescing
@bradzacher bradzacher force-pushed the array-pattern-null-type branch from e4f86f0 to f36da78 Jan 14, 2020
@codecov

This comment has been minimized.

Copy link

codecov bot commented Jan 14, 2020

Codecov Report

Merging #1451 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master   #1451      +/-   ##
=========================================
+ Coverage    94.1%   94.1%   +<.01%     
=========================================
  Files         143     143              
  Lines        6458    6459       +1     
  Branches     1824    1824              
=========================================
+ Hits         6077    6078       +1     
  Misses        204     204              
  Partials      177     177
Impacted Files Coverage Δ
...nt-plugin/src/rules/indent-new-do-not-use/index.ts 98.4% <100%> (ø) ⬆️
@bradzacher bradzacher merged commit 62e4ca0 into master Jan 14, 2020
7 checks passed
7 checks passed
Semantic Pull Request ready to be squashed
Details
codecov/patch 100% of diff hit (target 90%)
Details
codecov/project 94.1% (+<.01%) compared to 4726605
Details
typescript-eslint.typescript-eslint Build #20200114.9 succeeded
Details
typescript-eslint.typescript-eslint (Primary code validation and tests) Primary code validation and tests succeeded
Details
typescript-eslint.typescript-eslint (Run unit tests on other Node.js versions node_10_x) Run unit tests on other Node.js versions node_10_x succeeded
Details
typescript-eslint.typescript-eslint (Run unit tests on other Node.js versions node_8_x) Run unit tests on other Node.js versions node_8_x succeeded
Details
@bradzacher bradzacher deleted the array-pattern-null-type branch Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.