Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix vscode launch configuration for windows #1523

Merged
merged 5 commits into from Jan 26, 2020

Conversation

@armano2
Copy link
Member

armano2 commented Jan 25, 2020

fixes #1519

armano2 added 2 commits Jan 25, 2020
@armano2 armano2 added the tests label Jan 25, 2020
@armano2 armano2 self-assigned this Jan 25, 2020
@typescript-eslint

This comment was marked as resolved.

Copy link

typescript-eslint bot commented Jan 25, 2020

Thanks for the PR, @armano2!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@codecov

This comment has been minimized.

Copy link

codecov bot commented Jan 26, 2020

Codecov Report

Merging #1523 into master will not change coverage.
The diff coverage is 96.87%.

@@           Coverage Diff           @@
##           master    #1523   +/-   ##
=======================================
  Coverage   95.49%   95.49%           
=======================================
  Files         150      150           
  Lines        6639     6639           
  Branches     1880     1880           
=======================================
  Hits         6340     6340           
  Misses        112      112           
  Partials      187      187
Impacted Files Coverage Δ
...-plugin/src/rules/explicit-function-return-type.ts 100% <100%> (ø) ⬆️
.../eslint-plugin/src/util/explicitReturnTypeUtils.ts 100% <100%> (ø) ⬆️
packages/eslint-plugin/src/util/astUtils.ts 84.37% <80%> (ø) ⬆️
...plugin/src/rules/explicit-module-boundary-types.ts 85.45% <94.44%> (ø) ⬆️
"--runInBand",
"--no-cache",
"--no-coverage",
"${fileBasename}"

This comment has been minimized.

Copy link
@bradzacher

bradzacher Jan 26, 2020

Member

This should be fileBasenameNoExtension
fileBasename will include .ts, which means you can only run the test if you open the test file (because semi.ts won't match semi.test.ts)

Suggested change
"${fileBasename}"
"${fileBasenameNoExtension}"
"--runInBand",
"--no-cache",
"--no-coverage",
"${fileBasename}"

This comment has been minimized.

Copy link
@bradzacher

bradzacher Jan 26, 2020

Member
Suggested change
"${fileBasename}"
"${fileBasenameNoExtension}"
armano2 added 2 commits Jan 26, 2020
@bradzacher bradzacher merged commit 03221d2 into typescript-eslint:master Jan 26, 2020
7 checks passed
7 checks passed
Semantic Pull Request ready to be squashed
Details
codecov/patch 96.87% of diff hit (target 90%)
Details
codecov/project 95.49% (+0%) compared to f991764
Details
typescript-eslint.typescript-eslint Build #20200126.15 succeeded
Details
typescript-eslint.typescript-eslint (Primary code validation and tests) Primary code validation and tests succeeded
Details
typescript-eslint.typescript-eslint (Run unit tests on other Node.js versions node_10_x) Run unit tests on other Node.js versions node_10_x succeeded
Details
typescript-eslint.typescript-eslint (Run unit tests on other Node.js versions node_8_x) Run unit tests on other Node.js versions node_8_x succeeded
Details
@JoshuaKGoldberg

This comment has been minimized.

Copy link
Contributor

JoshuaKGoldberg commented Jan 26, 2020

Thank you!

@armano2 armano2 deleted the armano2:vscode-launch branch Jan 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can’t perform that action at this time.