feat(eslint-plugin): [no-unnecessary-condition] remove checkArrayPredicates and always check it
#1579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR, @Retsam! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! |
Retsam
commented
Feb 7, 2020
Retsam
force-pushed
the
no-array-callback-option
branch
from
ccedabf
to
59f0736
Compare
bradzacher
added
breaking change
Codecov Report
@@ Coverage Diff @@
## v3 #1579 +/- ##
=======================================
Coverage 93.63% 93.63%
=======================================
Files 169 169
Lines 7667 7667
Branches 2190 2190
=======================================
Hits 7179 7179
Misses 229 229
Partials 259 259
|
Retsam
force-pushed
the
no-array-callback-option
branch
from
59f0736
to
9040423
Compare
# Conflicts: # packages/eslint-plugin/src/rules/no-unnecessary-condition.ts # packages/eslint-plugin/tests/rules/no-unnecessary-condition.test.ts
bradzacher
changed the title
checkArrayPredicates and always check it
bradzacher
pushed a commit
that referenced
this pull request
May 11, 2020
…dicates` and always check it (#1579)
bradzacher
pushed a commit
that referenced
this pull request
May 14, 2020
…dicates` and always check it (#1579)
bradzacher
pushed a commit
that referenced
this pull request
May 17, 2020
…dicates` and always check it (#1579)
bradzacher
pushed a commit
that referenced
this pull request
May 21, 2020
…dicates` and always check it (#1579)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
BREAKING CHANGE:
This removes the
checkArrayPredicatesoption, and enables it as the default behavior of the rule. I think this makes sense as default, non-configurable behavior: I don't really see a case where you wouldn't want the unnecessary condition logic to apply to array predicates which function as conditionals.