Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint-plugin): [dot-notation] handle missing declarations #1947

merged 1 commit into from Apr 29, 2020


Copy link

also minor perf improvement

Fixes #1945

@bradzacher bradzacher added the bug Something isn't working label Apr 28, 2020
Copy link

Thanks for the PR, @bradzacher!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

Copy link

codecov bot commented Apr 28, 2020

Codecov Report

Merging #1947 into master will decrease coverage by 0.01%.
The diff coverage is 60.00%.

@@            Coverage Diff             @@
##           master    #1947      +/-   ##
- Coverage   94.36%   94.35%   -0.02%     
  Files         168      168              
  Lines        7664     7664              
  Branches     2204     2204              
- Hits         7232     7231       -1     
  Misses        183      183              
- Partials      249      250       +1     
Flag Coverage Δ
#unittest 94.35% <60.00%> (-0.02%) ⬇️
Impacted Files Coverage Δ
packages/eslint-plugin/src/rules/dot-notation.ts 86.66% <60.00%> (-6.67%) ⬇️

@bradzacher bradzacher merged commit 383f931 into master Apr 29, 2020
@bradzacher bradzacher deleted the 1945-dot-notation branch April 30, 2020 07:02
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
bug Something isn't working
None yet

Successfully merging this pull request may close these issues.

[dot-notation] Cannot read property '0' of undefined
1 participant