Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint-plugin): [method-signature-style] fix overloaded methods to an intersection type #1966



Copy link

Fixes #1911

Copy link

Thanks for the PR, @sosukesuzuki!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

Copy link

codecov bot commented May 2, 2020

Codecov Report

Merging #1966 into master will increase coverage by 0.00%.
The diff coverage is 86.95%.

@@           Coverage Diff           @@
##           master    #1966   +/-   ##
  Coverage   93.88%   93.89%           
  Files         170      170           
  Lines        7737     7765   +28     
  Branches     2227     2236    +9     
+ Hits         7264     7291   +27     
+ Misses        218      217    -1     
- Partials      255      257    +2     
Flag Coverage Δ
#unittest 93.89% <86.95%> (+<0.01%) ⬆️
Impacted Files Coverage Δ
.../eslint-plugin/src/rules/method-signature-style.ts 92.85% <86.95%> (+1.36%) ⬆️
packages/eslint-plugin/src/rules/unbound-method.ts 95.23% <0.00%> (ø)
...kages/eslint-plugin/src/rules/no-base-to-string.ts 98.00% <0.00%> (+0.04%) ⬆️
packages/eslint-plugin/src/rules/return-await.ts 95.94% <0.00%> (+0.23%) ⬆️

@bradzacher bradzacher added the bug Something isn't working label May 2, 2020
Copy link

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for this.

One change that I just made so I can merge this right now: documented it in the readme.

@bradzacher bradzacher changed the title fix(eslint-plugin): [method-signature-style] Use intersection types instead of overload fix(eslint-plugin): [method-signature-style] fix overloaded methods to an intersection type May 4, 2020
@bradzacher bradzacher merged commit 7f3fba3 into typescript-eslint:master May 4, 2020
@sosukesuzuki sosukesuzuki deleted the fix-method-signature branch May 4, 2020 06:39
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
bug Something isn't working
None yet

Successfully merging this pull request may close these issues.

[method-signature-style] Autofixer generates uncompilable code
2 participants