Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint-plugin): [no-type-alias] handle readonly types in aliases #1990

merged 1 commit into from May 11, 2020


Copy link

Fixes #1981

Copy link

Thanks for the PR, @nicolashenry!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

Copy link

codecov bot commented May 8, 2020

Codecov Report

Merging #1990 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1990   +/-   ##
  Coverage   93.91%   93.91%           
  Files         171      171           
  Lines        7789     7789           
  Branches     2240     2240           
  Hits         7315     7315           
  Misses        217      217           
  Partials      257      257           
Flag Coverage Δ
#unittest 93.91% <ø> (ø)
Impacted Files Coverage Δ
packages/eslint-plugin/src/rules/no-type-alias.ts 100.00% <ø> (ø)

@bradzacher bradzacher added the bug Something isn't working label May 8, 2020
Copy link

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! thanks

@bradzacher bradzacher merged commit 56d9870 into typescript-eslint:master May 11, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
bug Something isn't working
None yet

Successfully merging this pull request may close these issues.

[no-type-alias] Unhandled in union types are not allowed using "readonly string[]"
2 participants