Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(experimental-utils): remove accidental dep on json-schema #2010

merged 1 commit into from May 11, 2020


Copy link

Fixes #2009

@bradzacher bradzacher added the bug Something isn't working label May 11, 2020
Copy link

Thanks for the PR, @bradzacher!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

Copy link

codecov bot commented May 11, 2020

Codecov Report

Merging #2010 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #2010      +/-   ##
+ Coverage   93.92%   93.93%   +0.01%     
  Files         171      171              
  Lines        7799     7816      +17     
  Branches     2243     2243              
+ Hits         7325     7342      +17     
  Misses        217      217              
  Partials      257      257              
Flag Coverage Δ
#unittest 93.93% <100.00%> (+0.01%) ⬆️
Impacted Files Coverage Δ
packages/experimental-utils/src/json-schema.ts 100.00% <100.00%> (ø)

@bradzacher bradzacher merged commit 1875fba into master May 11, 2020
@bradzacher bradzacher deleted the 2009-fix-json-schema branch May 11, 2020 20:05
AnonymerNiklasistanonym added a commit to AnonymerNiklasistanonym/MarkTeX that referenced this pull request May 11, 2020
- Fix test that crashes with stable inkscape version
- Sort rules of eslint and convert string keys to keys
- Specify exact version of eslint that otherwise crashes the linter currently (typescript-eslint/typescript-eslint#2010)
- Add eslint rule to catch non awaited promises (very helpful rule)
Copy link


Copy link

pls Release a new version asap

Copy link
Member Author

This has been released to our canary tag. It will be released to the latest tag when time permits.

@typescript-eslint typescript-eslint locked and limited conversation to collaborators May 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
bug Something isn't working
None yet

Successfully merging this pull request may close these issues.

Cannot find module 'json-schema'
3 participants