New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(experimental-utils): upgrade eslint types for v7 #2023
Conversation
BREAKING CHANGE: - Renames some interfaces to be closer to the underlying ESLint definitions. - Changes the definitions to use `declare class` instead of interface types so they're a little more sane. - Marks a lot of properties as readonly - some because it's correct (eg context and source code) - some because it makes some things easier - Removed types for APIs that have been deprecated. - Some had been deprecated for 3 major versions - it's time to move on. - Removed deprecated parser options. Added a lot of jsdoc to the types. Like a lot. Some taken from eslint's site, some taken from the source code.
Thanks for the PR, @bradzacher! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! |
Codecov Report
@@ Coverage Diff @@
## v3 #2023 +/- ##
==========================================
- Coverage 93.61% 93.61% -0.01%
==========================================
Files 169 170 +1
Lines 7680 7679 -1
Branches 2195 2193 -2
==========================================
- Hits 7190 7189 -1
Misses 231 231
Partials 259 259
|
BREAKING CHANGE:
declare class
instead of interface types so they're a little more sane.Added a lot of jsdoc to the types. Like a lot. Some taken from eslint's site, some taken from the source code.