Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(experimental-utils): export CLIEngine & ESLint #2083

merged 1 commit into from May 24, 2020

fix(experimental-utils): export CLIEngine & ESLint #2083

merged 1 commit into from May 24, 2020


Copy link

@G-Rath G-Rath commented May 24, 2020

I can't find any reason why they're not exported already, but I could have missed something.

Copy link

Thanks for the PR, @G-Rath!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

Copy link

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah these should be exported. I missed them!

Copy link

codecov bot commented May 24, 2020

Codecov Report

Merging #2083 into master will increase coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #2083      +/-   ##
+ Coverage   93.40%   93.45%   +0.05%     
  Files         171      171              
  Lines        7745     7747       +2     
  Branches     2210     2210              
+ Hits         7234     7240       +6     
+ Misses        246      242       -4     
  Partials      265      265              
Flag Coverage Δ
#unittest 93.45% <100.00%> (+0.05%) ⬆️
Impacted Files Coverage Δ
packages/experimental-utils/src/ts-eslint/index.ts 100.00% <100.00%> (ø)
...ackages/experimental-utils/src/ts-eslint/ESLint.ts 100.00% <0.00%> (+100.00%) ⬆️
...ages/experimental-utils/src/ts-eslint/CLIEngine.ts 100.00% <0.00%> (+100.00%) ⬆️

@bradzacher bradzacher added the bug Something isn't working label May 24, 2020
@bradzacher bradzacher merged commit 014341b into typescript-eslint:master May 24, 2020
@G-Rath G-Rath deleted the patch-3 branch May 24, 2020 02:39
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
bug Something isn't working
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants