Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint-plugin): [no-throw-literal] handle intersection and union types #2085

merged 2 commits into from May 25, 2020


Copy link

fixes #1841

Copy link

Thanks for the PR, @yeonjuan!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

Copy link

codecov bot commented May 24, 2020

Codecov Report

Merging #2085 into master will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #2085      +/-   ##
+ Coverage   93.43%   93.45%   +0.02%     
  Files         171      171              
  Lines        7749     7751       +2     
  Branches     2211     2212       +1     
+ Hits         7240     7244       +4     
+ Misses        243      242       -1     
+ Partials      266      265       -1     
Flag Coverage Δ
#unittest 93.45% <100.00%> (+0.02%) ⬆️
Impacted Files Coverage Δ
...ckages/eslint-plugin/src/rules/no-throw-literal.ts 96.07% <100.00%> (+0.33%) ⬆️
packages/eslint-plugin/src/rules/unbound-method.ts 95.23% <0.00%> (+2.93%) ⬆️

@bradzacher bradzacher added the bug Something isn't working label May 24, 2020
Copy link

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

easy peasy!
thanks for this

@bradzacher bradzacher changed the title fix(eslint-plugin): [no-throw-literal] treat intersection, union type fix(eslint-plugin): [no-throw-literal] handle intersection and union types May 25, 2020
@bradzacher bradzacher merged commit cae037f into typescript-eslint:master May 25, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
bug Something isn't working
None yet

Successfully merging this pull request may close these issues.

[no-throw-literal] assumes intersection types are not errors
2 participants