Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint-plugin): [naming-convention] handle no options correctly #2095

merged 1 commit into from May 25, 2020


Copy link

Fixes #2092

@bradzacher bradzacher added the bug Something isn't working label May 25, 2020
Copy link

Thanks for the PR, @bradzacher!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

Copy link

codecov bot commented May 25, 2020

Codecov Report

Merging #2095 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #2095      +/-   ##
+ Coverage   93.43%   93.44%   +0.01%     
  Files         171      171              
  Lines        7753     7753              
  Branches     2213     2214       +1     
+ Hits         7244     7245       +1     
  Misses        243      243              
+ Partials      266      265       -1     
Flag Coverage Δ
#unittest 93.44% <100.00%> (+0.01%) ⬆️
Impacted Files Coverage Δ
...kages/eslint-plugin/src/rules/naming-convention.ts 88.79% <100.00%> (+0.28%) ⬆️

@bradzacher bradzacher merged commit fd7d02b into master May 25, 2020
@bradzacher bradzacher deleted the naming-convention-empty-opts branch May 25, 2020 15:59
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
bug Something isn't working
None yet

Successfully merging this pull request may close these issues.

[naming-convention] Default options not applied
1 participant