Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(experimental-utils): downlevel type declarations for versions older than 3.8 #2133

merged 1 commit into from May 30, 2020


Copy link

Fixes #2114

Use downlevel-dts to do it.
I thought about just removing the private fields, but I think this is better for ensuring we don't cause regressions going forward.

Also it sets a precedence that I will leverage as part of #1939.

@bradzacher bradzacher added the bug Something isn't working label May 30, 2020
Copy link

Thanks for the PR, @bradzacher!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

Copy link

codecov bot commented May 30, 2020

Codecov Report

Merging #2133 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2133   +/-   ##
  Coverage   93.42%   93.42%           
  Files         171      171           
  Lines        7755     7755           
  Branches     2215     2215           
  Hits         7245     7245           
  Misses        244      244           
  Partials      266      266           
Flag Coverage Δ
#unittest 93.42% <ø> (ø)

@bradzacher bradzacher merged commit 7925823 into master May 30, 2020
@bradzacher bradzacher deleted the downlevel-dts branch May 30, 2020 21:54
Copy link

TIL about downlevel-dts. neat!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
bug Something isn't working
None yet

Successfully merging this pull request may close these issues.

experimental-utils v3.0 requires TS 3.8 compiler and ES2015 target
2 participants