Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint-plugin): [no-unnecessary-conditionals] Handle comparison of generics and loose comparisons with undefined values #2152

merged 1 commit into from Jun 2, 2020


Copy link

Follow-up for #2123 (comment)

…f generics and loose comparisons with undefined values
Copy link

Thanks for the PR, @umidbekkarimov!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@bradzacher bradzacher added the bug Something isn't working label Jun 2, 2020
Copy link

codecov bot commented Jun 2, 2020

Codecov Report

Merging #2152 into master will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #2152      +/-   ##
- Coverage   93.56%   93.53%   -0.03%     
  Files         171      171              
  Lines        7811     7814       +3     
  Branches     2229     2228       -1     
+ Hits         7308     7309       +1     
- Misses        244      245       +1     
- Partials      259      260       +1     
Flag Coverage Δ
#unittest 93.53% <100.00%> (-0.03%) ⬇️
Impacted Files Coverage Δ
...slint-plugin/src/rules/no-unnecessary-condition.ts 97.31% <100.00%> (+0.05%) ⬆️
packages/eslint-plugin/src/util/types.ts 81.21% <0.00%> (-1.22%) ⬇️

Copy link

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - thanks for the follow up!

@bradzacher bradzacher merged commit c86e2a2 into typescript-eslint:master Jun 2, 2020
@avocadowastaken avocadowastaken deleted the no-unnecessary-conditionals branch June 3, 2020 05:42
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
bug Something isn't working
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants