Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint-plugin): [explicit-module-boundary-types] dont report return type errors on constructor overloads #2158

merged 1 commit into from Jun 2, 2020


Copy link

Fixes #2150

@bradzacher bradzacher added the bug Something isn't working label Jun 2, 2020
Copy link

Thanks for the PR, @bradzacher!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

Copy link

codecov bot commented Jun 2, 2020

Codecov Report

Merging #2158 into master will decrease coverage by 0.00%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##           master    #2158      +/-   ##
- Coverage   93.55%   93.54%   -0.01%     
  Files         171      171              
  Lines        7799     7812      +13     
  Branches     2225     2230       +5     
+ Hits         7296     7308      +12     
  Misses        244      244              
- Partials      259      260       +1     
Flag Coverage Δ
#unittest 93.54% <50.00%> (-0.01%) ⬇️
Impacted Files Coverage Δ
...plugin/src/rules/explicit-module-boundary-types.ts 89.23% <50.00%> (-0.70%) ⬇️
...slint-plugin/src/rules/no-unnecessary-condition.ts 97.26% <0.00%> (+0.24%) ⬆️

@bradzacher bradzacher merged commit 53232d7 into master Jun 2, 2020
@bradzacher bradzacher deleted the 2150-embt-constructor-overloads branch June 2, 2020 23:01
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
bug Something isn't working
None yet

Successfully merging this pull request may close these issues.

[explicit-module-boundary-types] Warns on constructor overload
1 participant