Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint-plugin): [no-unused-expressions] handle ternary and short-circuit options #2194

merged 2 commits into from Jun 9, 2020


Copy link

@yeonjuan yeonjuan commented Jun 8, 2020

Fixes #1764 馃榿

Copy link

Thanks for the PR, @yeonjuan!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

馃檹 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@bradzacher bradzacher added the bug Something isn't working label Jun 8, 2020
Copy link

codecov bot commented Jun 8, 2020

Codecov Report

Merging #2194 into master will decrease coverage by 0.00%.
The diff coverage is 90.00%.

@@            Coverage Diff             @@
##           master    #2194      +/-   ##
- Coverage   93.42%   93.41%   -0.01%     
  Files         173      173              
  Lines        7861     7868       +7     
  Branches     2242     2246       +4     
+ Hits         7344     7350       +6     
- Misses        245      246       +1     
  Partials      272      272              
Flag Coverage 螖
#unittest 93.41% <90.00%> (-0.01%) 猬囷笍
Impacted Files Coverage 螖
...s/eslint-plugin/src/rules/no-unused-expressions.ts 94.11% <90.00%> (-5.89%) 猬囷笍

Copy link

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for this!

@bradzacher bradzacher changed the title fix(eslint-plugin): [no-unused-expressions] handling options fix(eslint-plugin): [no-unused-expressions] handle ternary and short-circuit options Jun 9, 2020
@bradzacher bradzacher merged commit ee9f100 into typescript-eslint:master Jun 9, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
bug Something isn't working
None yet

Successfully merging this pull request may close these issues.

[no-unused-expressions] no-unused-expressions works not as expected with optional chaining and condition
2 participants