Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eslint-plugin): [naming-convention] allow selecting only const variables #2291

Merged

Conversation

GavinWu1991
Copy link
Contributor

@GavinWu1991 GavinWu1991 commented Jul 13, 2020

As mentioned in the issue #1612, add more options to the naming convention rule for selecting only const variables.

@typescript-eslint
Copy link
Contributor

@typescript-eslint typescript-eslint bot commented Jul 13, 2020

Thanks for the PR, @GavinWu1991!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@codecov
Copy link

@codecov codecov bot commented Jul 13, 2020

Codecov Report

Merging #2291 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #2291   +/-   ##
=======================================
  Coverage   93.11%   93.11%           
=======================================
  Files         283      283           
  Lines        9061     9067    +6     
  Branches     2483     2485    +2     
=======================================
+ Hits         8437     8443    +6     
  Misses        301      301           
  Partials      323      323           
Flag Coverage Δ
#unittest 93.11% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...kages/eslint-plugin/src/rules/naming-convention.ts 89.01% <100.00%> (+0.18%) ⬆️

@bradzacher bradzacher added the enhancement: plugin rule option label Jul 13, 2020
Copy link
Member

@bradzacher bradzacher left a comment

nice and easy. thanks for this!

@bradzacher bradzacher changed the title feat(eslint-plugin): [naming-convention] allow selecting only const variables feat(eslint-plugin): [naming-convention] allow selecting only const variables Jul 20, 2020
@bradzacher bradzacher merged commit 156d058 into typescript-eslint:master Jul 20, 2020
10 checks passed
@GavinWu1991
Copy link
Contributor Author

@GavinWu1991 GavinWu1991 commented Jul 20, 2020

nice and easy. thanks for this!

Thx, I will continue contribute to the project.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement: plugin rule option
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants