Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eslint-plugin): [no-empty-function] add decoratedFunctions option #2295

Merged
merged 1 commit into from Jul 20, 2020

Conversation

a-tarasyuk
Copy link
Contributor

@a-tarasyuk a-tarasyuk commented Jul 14, 2020

Fixes #2278

@typescript-eslint
Copy link
Contributor

@typescript-eslint typescript-eslint bot commented Jul 14, 2020

Thanks for the PR, @a-tarasyuk!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@codecov
Copy link

@codecov codecov bot commented Jul 14, 2020

Codecov Report

Merging #2295 into master will decrease coverage by 0.01%.
The diff coverage is 84.61%.

@@            Coverage Diff             @@
##           master    #2295      +/-   ##
==========================================
- Coverage   93.12%   93.10%   -0.02%     
==========================================
  Files         283      283              
  Lines        9057     9069      +12     
  Branches     2482     2489       +7     
==========================================
+ Hits         8434     8444      +10     
  Misses        301      301              
- Partials      322      324       +2     
Flag Coverage Δ
#unittest 93.10% <84.61%> (-0.02%) ⬇️
Impacted Files Coverage Δ
...kages/eslint-plugin/src/rules/no-empty-function.ts 83.78% <84.61%> (-0.22%) ⬇️

@bradzacher bradzacher added the enhancement: plugin rule option label Jul 14, 2020
Copy link
Member

@bradzacher bradzacher left a comment

ezpz.
thanks for your contribution!

@bradzacher bradzacher changed the title feat(eslint-plugin): [no-empty-function] add decoratedFunctions option feat(eslint-plugin): [no-empty-function] add decoratedFunctions option Jul 20, 2020
@bradzacher bradzacher merged commit 88f08f4 into typescript-eslint:master Jul 20, 2020
9 of 10 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement: plugin rule option
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants