Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint-plugin): [adjacent-overload-signatures] fix false positive on call signatures and a method named call #2313

Merged
merged 1 commit into from Jul 20, 2020

Conversation

magurotuna
Copy link
Contributor

@magurotuna magurotuna commented Jul 20, 2020

Fixes #2312

This false positive occurred because CallSignature and normal methods named call were treated identically.
So I've fixed how to decide two methods are same or not.

@typescript-eslint
Copy link
Contributor

@typescript-eslint typescript-eslint bot commented Jul 20, 2020

Thanks for the PR, @magurotuna!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@codecov
Copy link

@codecov codecov bot commented Jul 20, 2020

Codecov Report

Merging #2313 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #2313   +/-   ##
=======================================
  Coverage   93.10%   93.10%           
=======================================
  Files         283      283           
  Lines        9079     9081    +2     
  Branches     2492     2493    +1     
=======================================
+ Hits         8453     8455    +2     
  Misses        301      301           
  Partials      325      325           
Flag Coverage Δ
#unittest 93.10% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...t-plugin/src/rules/adjacent-overload-signatures.ts 93.33% <100.00%> (+0.31%) ⬆️

@bradzacher bradzacher added the bug label Jul 20, 2020
Copy link
Member

@bradzacher bradzacher left a comment

LGTM - thanks heaps for filing and fixing this bug!

@bradzacher bradzacher merged commit 30fafb0 into typescript-eslint:master Jul 20, 2020
10 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants